openstack/trove
Code Issues Proposed changes

Port test_pagination on Python 3

Browse Source 
* test_pagination: use an empty string rather None as marker for
  bisect. On Python 3, a comparison between None and strings now
  raises a TypeError.
* Remove test_pagination from blacklist-py3.txt to run it on Python 3

Partially implements: blueprint trove-python3
Change-Id: I0c9c7d064ef7df2b15b40029264c33c9e9c9393e
This commit is contained in:
Victor Stinner 2016-06-23 09:30:22 +02:00
parent 091c255b67
commit 3bd6496998
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
blacklist-py3.txt
View File

@ -3,7 +3,6 @@
backup.test_backup_models
cluster.test_galera_cluster
cluster.test_redis_cluster
common.test_pagination
guestagent.test_cassandra_manager
guestagent.test_dbaas
guestagent.test_mongodb_manager

2
trove/tests/unittests/common/test_pagination.py
View File

@ -42,7 +42,7 @@ class TestPaginatedDataView(trove_testtools.TestCase):
next_page_marker=52)
self.assertEqual("52", view.next_page_marker)
def _do_paginate_list(self, limit=None, marker=None, include_marker=False):
def _do_paginate_list(self, limit=None, marker='', include_marker=False):
li = ['a', 'b', 'c', 'd', 'e']
return pagination.paginate_list(li, limit=limit, marker=marker,
include_marker=include_marker)