From 515afe532383f1163dc3e145e33d9dae0cffd21f Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Wed, 1 Feb 2017 21:18:24 +0100 Subject: [PATCH] Prepare for using standard python tests Add simple script to setup mysql and postgresql databases, this script can be run by users during testing and will be run by CI systems for specific setup before running unit tests. This allows to change in project-config the python-db jobs to python-jobs since python-jobs will call this script initially. Update CONTRIBUTING for this. See also http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html Change-Id: I3463e75057d0d4544f6a0212da888759ab5e171b Needed-By: I92e6e6502c2c516babf2bf66f3514875f77c460e --- CONTRIBUTING.rst | 4 ++++ tools/test-setup.sh | 57 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+) create mode 100755 tools/test-setup.sh diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 6bf4276d0a..9242f34ab1 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -319,3 +319,7 @@ If you want to run only the tests in one file you can use testtools e.g. .. code-block:: bash $ python -m testtools.run trove.tests.unittests.python.module.path + +Note that some unit tests can use an existing database. The script +``tools/test-setup.sh`` sets up the database for CI jobs and can be +used for local setup. diff --git a/tools/test-setup.sh b/tools/test-setup.sh new file mode 100755 index 0000000000..07a078547b --- /dev/null +++ b/tools/test-setup.sh @@ -0,0 +1,57 @@ +#!/bin/bash -xe + +# This script will be run by OpenStack CI before unit tests are run, +# it sets up the test system as needed. +# Developers should setup their test systems in a similar way. + +# This setup needs to be run as a user that can run sudo. + +# The root password for the MySQL database; pass it in via +# MYSQL_ROOT_PW. +DB_ROOT_PW=${MYSQL_ROOT_PW:-insecure_slave} + +# This user and its password are used by the tests, if you change it, +# your tests might fail. +DB_USER=openstack_citest +DB_PW=openstack_citest + +sudo -H mysqladmin -u root password $DB_ROOT_PW + +# It's best practice to remove anonymous users from the database. If +# a anonymous user exists, then it matches first for connections and +# other connections from that host will not work. +sudo -H mysql -u root -p$DB_ROOT_PW -h localhost -e " + DELETE FROM mysql.user WHERE User=''; + FLUSH PRIVILEGES; + GRANT ALL PRIVILEGES ON *.* + TO '$DB_USER'@'%' identified by '$DB_PW' WITH GRANT OPTION;" + +# Now create our database. +mysql -u $DB_USER -p$DB_PW -h 127.0.0.1 -e " + SET default_storage_engine=MYISAM; + DROP DATABASE IF EXISTS openstack_citest; + CREATE DATABASE openstack_citest CHARACTER SET utf8;" + +# Same for PostgreSQL +# The root password for the PostgreSQL database; pass it in via +# POSTGRES_ROOT_PW. +DB_ROOT_PW=${POSTGRES_ROOT_PW:-insecure_slave} + +# Setup user +root_roles=$(sudo -H -u postgres psql -t -c " + SELECT 'HERE' from pg_roles where rolname='$DB_USER'") +if [[ ${root_roles} == *HERE ]];then + sudo -H -u postgres psql -c "ALTER ROLE $DB_USER WITH SUPERUSER LOGIN PASSWORD '$DB_PW'" +else + sudo -H -u postgres psql -c "CREATE ROLE $DB_USER WITH SUPERUSER LOGIN PASSWORD '$DB_PW'" +fi + +# Store password for tests +cat << EOF > $HOME/.pgpass +*:*:*:$DB_USER:$DB_PW +EOF +chmod 0600 $HOME/.pgpass + +# Now create our database +psql -h 127.0.0.1 -U $DB_USER -d template1 -c "DROP DATABASE IF EXISTS openstack_citest" +createdb -h 127.0.0.1 -U $DB_USER -l C -T template0 -E utf8 openstack_citest