Merge "Add unit tests for guestagent.db.models.py"

reddwarf/tests/unittests/guestagent/test_dbaas.py

@@ -160,13 +160,24 @@ class MySqlAdminTest(testtools.TestCase):
         self.mySqlAdmin.create_user(FAKE_USER)
         self.assertEqual(2, dbaas.LocalSqlClient.execute.call_count)
 
+
+class EnableRootTest(MySqlAdminTest):
+    def setUp(self):
+        super(EnableRootTest, self).setUp()
+        self.origin_is_valid_user_name = models.MySQLUser._is_valid_user_name
+        self.mySqlAdmin = MySqlAdmin()
+
+    def tearDown(self):
+        super(EnableRootTest, self).tearDown()
+        models.MySQLUser._is_valid_user_name = self.origin_is_valid_user_name
+
     def test_enable_root(self):
-        models.MySQLUser._is_valid_user_name = \
+        models.MySQLUser._is_valid_user_name =\
             MagicMock(return_value=True)
         self.mySqlAdmin.enable_root()
         self.assertEqual(3, dbaas.LocalSqlClient.execute.call_count)
 
     def test_enable_root_failed(self):
-        models.MySQLUser._is_valid_user_name = \
+        models.MySQLUser._is_valid_user_name =\
             MagicMock(return_value=False)
         self.assertRaises(ValueError, self.mySqlAdmin.enable_root)

reddwarf/tests/unittests/guestagent/test_dbmodels.py

@@ -0,0 +1,86 @@
+#    Copyright 2012 OpenStack LLC
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License
+import testtools
+from reddwarf.guestagent.db import models as dbmodels
+from mock import Mock, MagicMock
+
+
+class MySQLDatabaseTest(testtools.TestCase):
+
+    def setUp(self):
+        super(MySQLDatabaseTest, self).setUp()
+
+        self.mysqlDb = dbmodels.MySQLDatabase()
+        self.origin_ignore_db = self.mysqlDb._ignore_dbs
+        self.mysqlDb._ignore_dbs = ['mysql']
+
+    def tearDown(self):
+        super(MySQLDatabaseTest, self).tearDown()
+        self.mysqlDb._ignore_dbs = self.origin_ignore_db
+
+    def test_name(self):
+        self.assertIsNone(self.mysqlDb.name)
+
+    def test_name_setter(self):
+        test_name = "Anna"
+        self.mysqlDb.name = test_name
+        self.assertEqual(test_name, self.mysqlDb.name)
+
+    def test_is_valid_positive(self):
+        self.assertTrue(self.mysqlDb._is_valid('mysqldb'))
+
+    def test_is_valid_negative(self):
+        self.assertFalse(self.mysqlDb._is_valid('mysql'))
+
+
+class MySQLUserTest(testtools.TestCase):
+    def setUp(self):
+        super(MySQLUserTest, self).setUp()
+        self.mysqlUser = dbmodels.MySQLUser()
+
+    def tearDown(self):
+        super(MySQLUserTest, self).tearDown()
+
+    def test_is_valid_negative(self):
+        self.assertFalse(self.mysqlUser._is_valid(None))
+        self.assertFalse(self.mysqlUser._is_valid("|;"))
+        self.assertFalse(self.mysqlUser._is_valid("\\"))
+
+    def test_is_valid_positive(self):
+        self.assertTrue(self.mysqlUser._is_valid("real_name"))
+
+
+class IsValidUsernameTest(testtools.TestCase):
+    def setUp(self):
+        super(IsValidUsernameTest, self).setUp()
+        self.mysqlUser = dbmodels.MySQLUser()
+        self.origin_is_valid = self.mysqlUser._is_valid
+        self.origin_ignore_users = self.mysqlUser._ignore_users
+        self.mysqlUser._ignore_users = ["king"]
+
+    def tearDown(self):
+        super(IsValidUsernameTest, self).tearDown()
+        self.mysqlUser._is_valid = self.origin_is_valid
+        self.mysqlUser._ignore_users = self.origin_ignore_users
+
+    def test_is_valid_user_name(self):
+        value = "reddwarf"
+        self.assertTrue(self.mysqlUser._is_valid_user_name(value))
+
+    def test_is_valid_user_name_negative(self):
+        self.mysqlUser._is_valid = MagicMock(return_value=False)
+        self.assertFalse(self.mysqlUser._is_valid_user_name("reddwarf"))
+
+        self.mysqlUser._is_valid = MagicMock(return_value=True)
+        self.assertFalse(self.mysqlUser._is_valid_user_name("king"))