trove pylint cleanup(s)
This commit includes two cleanups in trove-pylint.
First, the deprecation warning is because the text.ParseableOutputFormat is
being deprecated[1] and produces a deprecation warning as shown in the
bug.
Second, while looking into 1650816, I stumbled upon 1650888
which is
also fixed. A block of code was wrongly indented and when I disabled
"-E" to generate warnings, produced a crash in pylint. If the line
generated doesn't match the regular expression, the various parameters
to the next call (to ignore()) are not set and you get unbound
variable errors.
[1] https://github.com/PyCQA/pylint/blob/master/pylint/reporters/text.py#L163
Change-Id: I43bd6569a98eeb1b326e4a0ca1addaf97c0830a5
Closes-Bug: #1650530
Closes-But: #1650888
This commit is contained in:
parent
8adfb7e4f2
commit
6d1349eb8b
@ -194,6 +194,13 @@ def usage():
|
|||||||
print("\t rebuild: rebuild the list of exceptions to ignore.")
|
print("\t rebuild: rebuild the list of exceptions to ignore.")
|
||||||
return 0
|
return 0
|
||||||
|
|
||||||
|
class ParseableTextReporter(text.TextReporter):
|
||||||
|
name = 'parseable'
|
||||||
|
line_format = '{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}'
|
||||||
|
|
||||||
|
# that's it folks
|
||||||
|
|
||||||
|
|
||||||
class LintRunner(object):
|
class LintRunner(object):
|
||||||
def __init__(self):
|
def __init__(self):
|
||||||
self.config = Config()
|
self.config = Config()
|
||||||
@ -204,7 +211,7 @@ class LintRunner(object):
|
|||||||
exceptions = set()
|
exceptions = set()
|
||||||
|
|
||||||
buffer = csio()
|
buffer = csio()
|
||||||
reporter = text.ParseableTextReporter(output=buffer)
|
reporter = ParseableTextReporter(output=buffer)
|
||||||
options = list(self.config.get('options'))
|
options = list(self.config.get('options'))
|
||||||
options.append(filename)
|
options.append(filename)
|
||||||
lint.Run(options, reporter=reporter, exit=False)
|
lint.Run(options, reporter=reporter, exit=False)
|
||||||
|
Loading…
Reference in New Issue
Block a user