openstack/trove
Code Issues Proposed changes

Define safe pid-file and socket paths in config

Browse Source 
Service manager cannot properly manage the MySQL
process if the pid file / socket are not defined
for the mysql_safe process.

Also rename 'pid_file' to 'pid-file', default for
both 5.6 and 5.7 and the only name accepted in the
'mysql_safe' section.

Update MySQL derivatives: MySQL, Percona and PXC.

Change-Id: I44441144a74e01d3c816ca72b2da4aa351dbd46c
Closes-Bug: 1605385
This commit is contained in:
Petr Malik 2016-05-12 20:36:40 -04:00
parent ecf4b675e8
commit 6f6a3f2af9
5 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apidocs/src/samples/db-get-default-instance-configuration-response-json.txt
View File

@ -1,5 +1,5 @@
HTTP/1.1 200 OK
Content-Type: application/json
Content-Length: 1094
Content-Length: 1135
Date: Mon, 18 Mar 2013 19:09:17 GMT

3
apidocs/src/samples/db-get-default-instance-configuration-response.json
View File

@ -20,7 +20,8 @@
"max_user_connections": 100,
"myisam-recover-options": "BACKUP,FORCE",
"open_files_limit": 512,
"pid_file": "/var/run/mysqld/mysqld.pid",
"pid-file": "/var/run/mysqld/mysqld.pid",
"socket": "/var/run/mysqld/mysqld.sock",
"port": 3306,
"query_cache_limit": "1M",
"query_cache_size": "8M",

6
trove/templates/mysql/config.template
View File

@ -1,7 +1,10 @@
[client]
port = 3306
socket = /var/run/mysqld/mysqld.sock
[mysqld_safe]
pid-file = /var/run/mysqld/mysqld.pid
socket = /var/run/mysqld/mysqld.sock
nice = 0
[mysqld]
@ -10,7 +13,8 @@ port = 3306
basedir = /usr
datadir = /var/lib/mysql/data
tmpdir = /var/tmp
pid_file = /var/run/mysqld/mysqld.pid
pid-file = /var/run/mysqld/mysqld.pid
socket = /var/run/mysqld/mysqld.sock
skip-external-locking = 1
key_buffer_size = {{ (50 * flavor['ram']/512)|int }}M
max_allowed_packet = {{ (1024 * flavor['ram']/512)|int }}K

6
trove/templates/percona/config.template
View File

@ -1,7 +1,10 @@
[client]
port = 3306
socket = /var/run/mysqld/mysqld.sock
[mysqld_safe]
pid-file = /var/run/mysqld/mysqld.pid
socket = /var/run/mysqld/mysqld.sock
nice = 0
[mysqld]
@ -10,7 +13,8 @@ port = 3306
basedir = /usr
datadir = /var/lib/mysql/data
tmpdir = /var/tmp
pid_file = /var/run/mysqld/mysqld.pid
pid-file = /var/run/mysqld/mysqld.pid
socket = /var/run/mysqld/mysqld.sock
skip-external-locking = 1
key_buffer_size = {{ (50 * flavor['ram']/512)|int }}M
max_allowed_packet = {{ (1024 * flavor['ram']/512)|int }}K

6
trove/templates/pxc/config.template
View File

@ -1,7 +1,10 @@
[client]
port = 3306
socket = /var/run/mysqld/mysqld.sock
[mysqld_safe]
pid-file = /var/run/mysqld/mysqld.pid
socket = /var/run/mysqld/mysqld.sock
nice = 0
[mysqld]
@ -10,7 +13,8 @@ port = 3306
basedir = /usr
datadir = /var/lib/mysql/data
tmpdir = /var/tmp
pid_file = /var/run/mysqld/mysqld.pid
pid-file = /var/run/mysqld/mysqld.pid
socket = /var/run/mysqld/mysqld.sock
skip-external-locking = 1
key_buffer_size = {{ (50 * flavor['ram']/512)|int }}M
max_allowed_packet = {{ (1024 * flavor['ram']/512)|int }}K