openstack/trove
Code Issues Proposed changes

Fix MariaDB scenario replication test

Browse Source 
When the binlog_format fix was put in for Percona and MySQL,
(see https://review.openstack.org/#/c/300253 )
MariaDB didn't need to be fixed. The scenario test was not set
up to handle the differences between the 3 flavors,
and has been fixed.

In a nutshell, MariaDB now expects to have 'STATEMENT' binlog
format, not 'MIXED' like the other two.

Change-Id: I1ced565ce18d5492126875c66fb74e85c091e15c
Closes-Bug: #1585384
This commit is contained in:
Peter Stachowski 2016-05-24 17:56:32 -04:00
parent dd49dc6e2e
commit 9464300fd6
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
trove/tests/scenario/runners/replication_runners.py
View File

@ -333,9 +333,12 @@ class MysqlReplicationRunner(ReplicationRunner):
def _validate_binlog_fmt(self, instance_id, client):
binlog_fmt = self._get_mysql_variable(client, 'binlog_format')
self.assert_equal('MIXED', binlog_fmt,
self.assert_equal(self._get_expected_binlog_format(), binlog_fmt,
'Wrong binlog format detected for %s' % instance_id)
def _get_expected_binlog_format(self):
return 'MIXED'
def _validate_read_only(self, instance_id, client):
read_only = self._get_mysql_variable(client, 'read_only')
self.assert_equal('ON', read_only, 'Wrong read only mode detected '
@ -352,4 +355,6 @@ class PerconaReplicationRunner(MysqlReplicationRunner):
class MariadbReplicationRunner(MysqlReplicationRunner):
pass
def _get_expected_binlog_format(self):
return 'STATEMENT'