From 9979d48442ae6dd1cddfcb0f1225c91b3d5bcacb Mon Sep 17 00:00:00 2001 From: Petr Malik Date: Fri, 12 Aug 2016 15:01:45 -0400 Subject: [PATCH] Tests verify cluster data via every node Cluster tests currently verify data only via the first node. This may easily miss bugs when data is not properly replicated within the cluster due to some configuration issue. Change-Id: I9e280aeaa1e83eb1902b83f64a5e1d5bf2ba7a4f --- .../runners/cluster_actions_runners.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/trove/tests/scenario/runners/cluster_actions_runners.py b/trove/tests/scenario/runners/cluster_actions_runners.py index 3d1425287f..870a20ea55 100644 --- a/trove/tests/scenario/runners/cluster_actions_runners.py +++ b/trove/tests/scenario/runners/cluster_actions_runners.py @@ -137,12 +137,14 @@ class ClusterActionsRunner(TestRunner): instance['id']) self.assert_true(root_enabled_test.rootEnabled) - ping_response = self.test_helper.ping( - cluster.ip[0], - username=self.current_root_creds[0], - password=self.current_root_creds[1] - ) - self.assert_true(ping_response) + for ip in cluster.ip: + self.report.log("Pinging cluster as superuser via node: %s" % ip) + ping_response = self.test_helper.ping( + ip, + username=self.current_root_creds[0], + password=self.current_root_creds[1] + ) + self.assert_true(ping_response) def run_add_initial_cluster_data(self, data_type=DataType.tiny): self.assert_add_cluster_data(data_type, self.cluster_id) @@ -162,7 +164,9 @@ class ClusterActionsRunner(TestRunner): def assert_verify_cluster_data(self, data_type, cluster_id): cluster = self.auth_client.clusters.get(cluster_id) - self.test_helper.verify_data(data_type, cluster.ip[0]) + for ip in cluster.ip: + self.report.log("Verifying cluster data via node: %s" % ip) + self.test_helper.verify_data(data_type, ip) def run_remove_initial_cluster_data(self, data_type=DataType.tiny): self.assert_remove_cluster_data(data_type, self.cluster_id)