openstack/trove
Code Issues Proposed changes

Remove admin_token from configs

Browse Source 
A previous review removed the admin_token from the sample config file.
It appears that devstack doesn't use that file but instead uses one of
the .test files.

Admin tokens are actively discouraged as a form of authenticating in
auth_token middleware and the behaviour when using admin_token in
combination with a username and password (as this default produces in
devstack) can lead to problems in authentication.

Closes-Bug: #1299332
Change-Id: I78d2c184f7937006b808d580e3663ab055f7c5fe
This commit is contained in:
Jamie Lennox 2014-05-23 13:02:45 +10:00
parent 5f019cc8bb
commit 9db80e79ea
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
etc/trove/api-paste.ini.test
View File

@ -22,7 +22,6 @@ auth_host = 127.0.0.1
auth_port = 35357
auth_protocol = http
auth_uri = http://127.0.0.1:5000/
admin_token = be19c524ddc92109a224
signing_dir = /tmp/keystone-signing-trove
[filter:authorization]

1
etc/trove/trove.conf.test
View File

@ -159,7 +159,6 @@ auth_host = 127.0.0.1
auth_port = 35357
auth_protocol = http
auth_uri = http://127.0.0.1:5000/
admin_token = be19c524ddc92109a224
[filter:authorization]
paste.filter_factory = trove.common.auth:AuthorizationMiddleware.factory