openstack/trove
Code Issues Proposed changes

Remove blacklist test volume

Browse Source 
Now,We have error in test volume in py3,I have modified the error.
replace NamedTemporaryFile(delete=False) -> NamedTemporaryFile
(mode='w', delete=False).That will open the temporary file in
the text mode.

Closes-Bug #1633789
Change-Id: I24f2fbd13eaacaa0efe5601490cdc08edcd4b1d2
This commit is contained in:
jiansong 2016-10-19 11:47:42 -07:00 committed by jian.song
parent 0afac6bef1
commit ba91e98068
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
blacklist-py3.txt
View File

@ -1,4 +1,3 @@
# Use a blacklist of tests known to fail on Python 3, until
# all unit tests will pass on Python 3.
guestagent.test_operating_system
guestagent.test_volume

2
trove/guestagent/volume.py
View File

@ -205,7 +205,7 @@ class VolumeMountPoint(object):
LOG.debug("Writing new line to fstab:%s" % fstab_line)
with open('/etc/fstab', "r") as fstab:
fstab_content = fstab.read()
with NamedTemporaryFile(delete=False) as tempfstab:
with NamedTemporaryFile(mode='w', delete=False) as tempfstab:
tempfstab.write(fstab_content + fstab_line)
utils.execute("sudo", "install", "-o", "root", "-g", "root", "-m",
"644", tempfstab.name, "/etc/fstab")