openstack/vitrage
Code Issues Proposed changes

dont use mutable default parameter

Browse Source 
Change-Id: Ifbe517542466e0620f5c7a101138aff624f85d61
This commit is contained in:
Eyal 2017-11-12 15:05:33 +02:00
parent 26257381ca
commit a48dbc9d54
4 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vitrage/api_handler/apis/template.py
View File

@ -34,7 +34,11 @@ class TemplateApis(object):
FAILED_MSG = 'validation failed' FAILED_MSG = 'validation failed'
OK_MSG = 'validation OK' OK_MSG = 'validation OK'
def __init__(self, templates, def_templates={}): def __init__(self, templates, def_templates=None):
if def_templates is None:
def_templates = {}
self.def_templates = def_templates self.def_templates = def_templates
self.templates = templates self.templates = templates

5
vitrage/evaluator/template_data.py
View File

@ -78,7 +78,10 @@ class TemplateData(object):
'operational_severity': VProps.VITRAGE_OPERATIONAL_SEVERITY 'operational_severity': VProps.VITRAGE_OPERATIONAL_SEVERITY
} }
def __init__(self, template_def, def_templates={}): def __init__(self, template_def, def_templates=None):
if def_templates is None:
def_templates = {}
self.name = template_def[TFields.METADATA][TFields.NAME] self.name = template_def[TFields.METADATA][TFields.NAME]
defs = {} defs = {}

5
vitrage/evaluator/template_validation/content/template_content_validator.py
View File

@ -49,7 +49,10 @@ from vitrage.utils import evaluator as evaluator_utils
LOG = log.getLogger(__name__) LOG = log.getLogger(__name__)
def content_validation(template, def_templates={}): def content_validation(template, def_templates=None):
if def_templates is None:
def_templates = {}
result = get_content_correct_result() result = get_content_correct_result()
entities_index = {} entities_index = {}

11
vitrage/tests/unit/evaluator/template_validation/content/test_template_content_validator.py
View File

@ -294,12 +294,19 @@ class TemplateContentValidatorTest(ValidatorTest):
def _execute_and_assert_with_fault_result(self, def _execute_and_assert_with_fault_result(self,
template, template,
status_code, status_code,
def_temps={}): def_temps=None):
if def_temps is None:
def_temps = {}
result = validator.content_validation(template, def_temps) result = validator.content_validation(template, def_temps)
self._assert_fault_result(result, status_code) self._assert_fault_result(result, status_code)
def _execute_and_assert_with_correct_result(self, template, def_temps={}): def _execute_and_assert_with_correct_result(self,
template,
def_temps=None):
if def_temps is None:
def_temps = {}
result = validator.content_validation(template, def_temps) result = validator.content_validation(template, def_temps)
self._assert_correct_result(result) self._assert_correct_result(result)