openstack/vitrage
Code Issues Proposed changes

Cleanup unused function

Browse Source 
extract_key` method is never used and itself is buggy, calling a protected
method and missing argument. It seems suppressed by `create_entity_key`

Change-Id: Ie0969e24538adb94113d46ae7b8f6a64cb76bb8a
This commit is contained in:
Yujun Zhang 2018-01-09 09:46:27 +08:00
parent 042858d98a
commit e0403bb3fe
5 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vitrage/entity_graph/transformer_manager.py
View File

@ -81,10 +81,6 @@ class TransformerManager(object):
entity_type = self.get_entity_type(entity_event)
return self.get_transformer(entity_type).get_enrich_query(entity_event)
def extract_key(self, entity_event):
entity_type = self.get_entity_type(entity_event)
return self.get_transformer(entity_type)._create_entity_key()
@staticmethod
def get_entity_type(entity_event):
try:

2
vitrage/tests/unit/datasources/nagios/test_nagios_transformer.py
View File

@ -57,7 +57,7 @@ class NagiosTransformerTest(base.BaseTest):
cls.transformers[NOVA_HOST_DATASOURCE] = \
HostTransformer(cls.transformers, cls.conf)
def test_extract_key(self):
def test_create_entity_key(self):
LOG.debug('Test get key from nova instance transformer')
# Test setup

2
vitrage/tests/unit/datasources/nova/test_nova_instance_transformer.py
View File

@ -234,7 +234,7 @@ class NovaInstanceTransformerTest(base.BaseTest):
self.assertEqual(edge.target_id, entity_uuid)
self.assertEqual(edge.label, EdgeLabel.CONTAINS)
def test_extract_key(self):
def test_create_entity_key(self):
LOG.debug('Test get key from nova instance transformer')
# Test setup

2
vitrage/tests/unit/datasources/nova/test_nova_zone_transformer.py
View File

@ -119,7 +119,7 @@ class NovaZoneTransformerTest(base.BaseTest):
)
self.assertEqual(zone_name, observed_key_fields[2])
def test_extract_key(self):
def test_create_entity_key(self):
pass
def test_snapshot_transform(self):

2
vitrage/tests/unit/datasources/zabbix/test_zabbix_transformer.py
View File

@ -59,7 +59,7 @@ class ZabbixTransformerTest(base.BaseTest):
cls.transformers[NOVA_HOST_DATASOURCE] = \
HostTransformer(cls.transformers, cls.conf)
def test_extract_key(self):
def test_create_entity_key(self):
LOG.debug('Test get key from nova instance transformer')
# Test setup