From ff4ef5ffbc4750cfed13b01596bef0683eff6817 Mon Sep 17 00:00:00 2001 From: Eyal Date: Sun, 23 Apr 2017 14:09:22 +0300 Subject: [PATCH] its a bad idea to use mutable default parameter Change-Id: I753b5d3c896b5d6622c63356b013d4f53edd4571 --- vitrage/datasources/rescheduler.py | 8 ++++++-- vitrage/tests/unit/datasources/aodh/test_aodh_driver.py | 5 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vitrage/datasources/rescheduler.py b/vitrage/datasources/rescheduler.py index 2594bf954..1bd9b5e0b 100644 --- a/vitrage/datasources/rescheduler.py +++ b/vitrage/datasources/rescheduler.py @@ -57,7 +57,7 @@ class ReScheduler(object): times=-1, ttl=None, fault_callback=None, - fault_callback_kwargs={}): + fault_callback_kwargs=None): """Schedule a new task :param func: function to run @@ -86,6 +86,8 @@ class ReScheduler(object): :return: None """ + if fault_callback_kwargs is None: + fault_callback_kwargs = {} if times == 0: return None @@ -140,8 +142,10 @@ class ReScheduler(object): times=-1, ttl=None, fault_callback=None, - fault_callback_kwargs={}): + fault_callback_kwargs=None): + if fault_callback_kwargs is None: + fault_callback_kwargs = {} self.scheduler = scheduler self.func = func self.args = args diff --git a/vitrage/tests/unit/datasources/aodh/test_aodh_driver.py b/vitrage/tests/unit/datasources/aodh/test_aodh_driver.py index 1f745b19f..74b69a534 100644 --- a/vitrage/tests/unit/datasources/aodh/test_aodh_driver.py +++ b/vitrage/tests/unit/datasources/aodh/test_aodh_driver.py @@ -184,9 +184,10 @@ class AodhDriverTest(base.BaseTest): def _extract_alarm_data(self, state="ok", type="event", - rule={"query": [], - "event_type": "*"}): + rule=None): + if rule is None: + rule = {"query": [], "event_type": "*"} return {AodhProps.DESCRIPTION: "test", AodhProps.TIMESTAMP: "2016-11-09T01:39:13.839584", AodhProps.ENABLED: True,