From da223d92b61656a05dea7336ccd08d0c784670f7 Mon Sep 17 00:00:00 2001 From: Thomas Herve Date: Wed, 3 Jun 2015 14:33:53 +0200 Subject: [PATCH] Tests refactoring spec Specification to get rid of the top-level tests directory. Change-Id: I9d7e0f34b298e736a0a8485cdd2edd0787a91f9a --- specs/liberty/index.rst | 4 +- specs/liberty/tests-refactoring.rst | 79 +++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+), 3 deletions(-) create mode 100644 specs/liberty/tests-refactoring.rst diff --git a/specs/liberty/index.rst b/specs/liberty/index.rst index a89b8f4..efc3285 100644 --- a/specs/liberty/index.rst +++ b/specs/liberty/index.rst @@ -6,6 +6,4 @@ :glob: :maxdepth: 2 -.. FIXME(flwang): Uncomment after adding first real spec. -.. * - + * diff --git a/specs/liberty/tests-refactoring.rst b/specs/liberty/tests-refactoring.rst new file mode 100644 index 0000000..b346abc --- /dev/null +++ b/specs/liberty/tests-refactoring.rst @@ -0,0 +1,79 @@ +.. + This template should be in ReSTructured text. The filename in the git + repository should match the launchpad URL, for example a URL of + https://blueprints.launchpad.net/zaqar/+spec/awesome-thing should be named + awesome-thing.rst. + + Please do not delete any of the sections in this + template. If you have nothing to say for a whole section, just write: None + + For help with syntax, see http://sphinx-doc.org/rest.html + To test out your formatting, see http://www.tele3.cz/jbar/rest/rest.html + +=================== + Tests refactoring +=================== + +Include the URL of your launchpad blueprint: + +https://blueprints.launchpad.net/zaqar/+spec/tests-refactoring + +Zaqar tests are currently split into 2 different places, we want to reunite +them. + +Problem description +=================== + +Tests currently exists in the tests top directory in the tree, but most of them +import abstract base classes from the zaqar.tests python package and set +attributes to be able to run them. There are also some tests definition in the +tests directory. It's not obvious that tests in the zaqar.tests package are not +run when using tox and in the gate, and it creates confusion on where the tests +should properly live. + +Proposed change +=============== + +Move all the tests in the zaqar.tests package, and delete the tests directory. + +To be able to have a reviewable stream, we will slowly add directories in +zaqar/tests to the testrepository configuration, and move them in small chunks. + +Alternatives +------------ + +None. + +Implementation +============== + +Assignee(s) +----------- + +Primary assignee: + therve + +Milestones +---------- + +Target Milestone for completion: + Liberty-1 + +Work Items +---------- + +1. Add one tests directory to .testr.conf and move the tests over +2. Iterate over all the tests directories in zaqar/tests +3. Move remaining tests out of tests/ + +Dependencies +============ + +None. + +.. note:: + + This work is licensed under a Creative Commons Attribution 3.0 + Unported License. + http://creativecommons.org/licenses/by/3.0/legalcode +