openstack/zaqar-tempest-plugin
Code Issues Proposed changes

Use assertEqual/GreaterEqual/LessEqual

Browse Source 
Instead of using assertFalse(A * B) / assertTrue(A * B),
developers should use assertEqual/GreaterEqual/LessEqual
The * operator: '==', '<=', '>='

Change-Id: If902f02dd20e3933e08513ca9de0ee46003e45f1
This commit is contained in:
Béla Vancsics 2016-03-01 13:21:37 +01:00
parent cb1ca87d3f
commit d5b72b719f
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zaqar/tests/tempest_plugin/tests/v1/test_claims.py
View File

@ -89,7 +89,7 @@ class TestClaims(base.BaseV1MessagingTest):
# Verify claim ttl >= updated ttl value
_, body = self.client.query_claim(claim_uri)
updated_claim_ttl = body["ttl"]
self.assertTrue(updated_claim_ttl >= claim_ttl)
self.assertGreaterEqual(updated_claim_ttl, claim_ttl)
# Delete Claimed message
self.client.delete_messages(claimed_message_uri)

2
zaqar/tests/tempest_plugin/tests/v1_1/test_claims.py
View File

@ -89,7 +89,7 @@ class TestClaims(base.BaseV11MessagingTest):
# Verify claim ttl >= updated ttl value
_, body = self.client.query_claim(claim_uri)
updated_claim_ttl = body["ttl"]
self.assertTrue(updated_claim_ttl >= claim_ttl)
self.assertGreaterEqual(updated_claim_ttl, claim_ttl)
# Delete Claimed message
self.client.delete_messages(claimed_message_uri)

2
zaqar/tests/tempest_plugin/tests/v2/test_claims.py
View File

@ -89,7 +89,7 @@ class TestClaims(base.BaseV2MessagingTest):
# Verify claim ttl >= updated ttl value
_, body = self.client.query_claim(claim_uri)
updated_claim_ttl = body["ttl"]
self.assertTrue(updated_claim_ttl >= claim_ttl)
self.assertGreaterEqual(updated_claim_ttl, claim_ttl)
# Delete Claimed message
self.client.delete_messages(claimed_message_uri)