From 4b2d8f4ba1472727ab166a7d449adb9ee2e12ac6 Mon Sep 17 00:00:00 2001 From: Flavio Percoco Date: Thu, 11 Sep 2014 16:51:22 +0200 Subject: [PATCH] Remove test_correct_has from our test suite This test is not reliable. Whenever it's executed outside a git repo or with a repo that has uncommited changes, it fails. Since this code has been stable for quite some time and it won't likely change in the future, I think it's safe to remove this test. Change-Id: I39a3dbd01ef189571f6dcf3ab4cd7a476733950a --- tests/unit/test_version.py | 37 ------------------------------------- 1 file changed, 37 deletions(-) delete mode 100644 tests/unit/test_version.py diff --git a/tests/unit/test_version.py b/tests/unit/test_version.py deleted file mode 100644 index 8e9befe8a..000000000 --- a/tests/unit/test_version.py +++ /dev/null @@ -1,37 +0,0 @@ -# Copyright (c) 2013 Rackspace, Inc. -# -# Licensed under the Apache License, Version 2.0 (the "License"); you may not -# use this file except in compliance with the License. You may obtain a copy -# of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT -# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the -# License for the specific language governing permissions and limitations under -# the License. - -import pbr.packaging - -import zaqar -from zaqar import tests as testing - - -class TestVersion(testing.TestBase): - - def test_correct_hash(self): - version = pbr.packaging._get_version_from_git('201X.X') - if version is None: - self.skipTest('Unable to obtain version from git') - - pre, sep, commit = version.rpartition('.') - - if not commit or not commit.startswith('g'): - self.skipTest('The git version string does not contain a hash') - - sha_abbrev = commit[1:] - self.assertTrue(zaqar.version.verify_sha(sha_abbrev)) - - sha_abbrev_bad = 'x' + sha_abbrev[1:] - self.assertFalse(zaqar.version.verify_sha(sha_abbrev_bad))