openstack/zaqar
Code Issues Proposed changes

Replace assertTrue(*>*) with assertGreater

Browse Source 
assertGreater will return nicer error if it fails.

Change-Id: I7dc315c46c9db6de076270ef6a69a05c8a402179
This commit is contained in:
Shu Yingya 2016-12-12 02:42:21 +00:00
parent 1313b625a5
commit 8d9be75590
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zaqar/tests/unit/transport/wsgi/v1/test_claims.py
View File

@ -182,7 +182,7 @@ class TestClaimsMongoDB(base.V1Base):
self.assertEqual(60, claim['ttl']) self.assertEqual(60, claim['ttl'])
estimated_age = timeutils.delta_seconds(creation, query) estimated_age = timeutils.delta_seconds(creation, query)
self.assertTrue(estimated_age > claim['age']) self.assertGreater(estimated_age, claim['age'])
# Delete the claim # Delete the claim
self.simulate_delete(claim['href'], 'bad_id') self.simulate_delete(claim['href'], 'bad_id')

2
zaqar/tests/unit/transport/wsgi/v1_1/test_claims.py
View File

@ -233,7 +233,7 @@ class TestClaimsMongoDB(base.V1_1Base):
self.assertEqual(60, claim['ttl']) self.assertEqual(60, claim['ttl'])
estimated_age = timeutils.delta_seconds(creation, query) estimated_age = timeutils.delta_seconds(creation, query)
self.assertTrue(estimated_age > claim['age']) self.assertGreater(estimated_age, claim['age'])
# Delete the claim # Delete the claim
self.simulate_delete(claim['href'], headers=self.headers) self.simulate_delete(claim['href'], headers=self.headers)

2
zaqar/tests/unit/transport/wsgi/v2_0/test_claims.py
View File

@ -234,7 +234,7 @@ class TestClaimsMongoDB(base.V2Base):
self.assertEqual(60, claim['ttl']) self.assertEqual(60, claim['ttl'])
estimated_age = timeutils.delta_seconds(creation, query) estimated_age = timeutils.delta_seconds(creation, query)
self.assertTrue(estimated_age > claim['age']) self.assertGreater(estimated_age, claim['age'])
# Delete the claim # Delete the claim
self.simulate_delete(claim['href'], headers=self.headers) self.simulate_delete(claim['href'], headers=self.headers)