openstack/zaqar
Code Issues Proposed changes

Retry container creation in swift

Browse Source 
Because of cache management container creation in Swift is somewhat
racy, as we create containers lazily. Work around that issue by retrying
creation a few times.

Change-Id: I4c3671cdb23df1597c2b5c9c581ad7225847d64d
Closes-Bug: #1719525
This commit is contained in:
Thomas Herve 2017-09-27 16:58:21 +02:00
parent 495ba042f4
commit b010ba13eb
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
zaqar/storage/swift/utils.py
View File

@ -42,8 +42,22 @@ def _put_or_create_container(client, *args, **kwargs):
client.put_object(*args, **kwargs)
except swiftclient.ClientException as e:
if e.http_status == 404:
client.put_container(args[0])
client.put_object(*args, **kwargs)
# Because of lazy creation, the container may be used by different
# clients and cause cache problem. Retrying object creation a few
# times should fix this.
for i in range(5):
client.put_container(args[0])
try:
client.put_object(*args, **kwargs)
except swiftclient.ClientException as ex:
if ex.http_status != 404:
raise
else:
break
else:
# If we got there, we ignored the 5th exception, so the
# exception context will be set.
raise
else:
raise