openstack/zaqar
Code Issues Proposed changes

WSGI: added the control for non empty X-PROJECT-ID

Browse Source 
Closes-bug: #1228249

Change-Id: I6fbf0344fd45f9581a28a55ef852139b32e93ed7
This commit is contained in:
Francesco Vollero 2013-09-27 00:56:31 +02:00
parent e8e3baef4e
commit c5d62ed385
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
marconi/queues/transport/wsgi/driver.py
View File

@ -52,6 +52,11 @@ media type support with the "Accept" header.''',
def _extract_project_id(req, resp, params):
params['project_id'] = req.get_header('X-PROJECT-ID')
if params['project_id'] == "":
raise falcon.HTTPBadRequest('Empty project header not allowed',
_(u'''
X-PROJECT-ID cannot be an empty string. Specify the right header X-PROJECT-ID
and retry.'''))
class Driver(transport.DriverBase):

17
tests/unit/queues/transport/wsgi/test_queue_lifecycle.py
View File

@ -36,7 +36,22 @@ class QueueLifecycleBaseTest(base.TestBase):
self.wsgi_cfg = config.namespace(
'drivers:transport:wsgi').from_options()
@ddt.data('480924', 'foo', '', None)
def test_empty_project_id(self):
path = '/v1/queues/gumshoe'
self.simulate_get(path, '')
self.assertEquals(self.srmock.status, falcon.HTTP_400)
self.simulate_put(path, '')
self.assertEquals(self.srmock.status, falcon.HTTP_400)
self.simulate_head(path, '')
self.assertEquals(self.srmock.status, falcon.HTTP_400)
self.simulate_delete(path, '')
self.assertEquals(self.srmock.status, falcon.HTTP_400)
@ddt.data('480924', 'foo', None)
def test_basics_thoroughly(self, project_id):
path = '/v1/queues/gumshoe'