openstack/zaqar
Code Issues Proposed changes

Using assertFalse(A) instead of assertEqual(False, A)

Browse Source 
This patch is to replace assertEqual(False, A) with assertFalse(A), which
the latter is more straightforward and easier to understand.

Similar to a merged patch https://review.openstack.org/#/c/473749/

Change-Id: I69c68326442bf394cd64bf55ce94333d39b56c70
This commit is contained in:
Van Hung Pham 2017-06-23 16:55:37 +07:00
parent 855e61eb58
commit cc6a4c22b5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zaqar/tests/unit/storage/base.py
View File

@ -1281,7 +1281,7 @@ class SubscriptionControllerTest(ControllerBaseTest):
subscription = self.subscription_controller.get(self.source, s_id,
project=self.project)
self.assertEqual(False, subscription['confirmed'])
self.assertFalse(subscription['confirmed'])
self.subscription_controller.confirm(self.source, s_id,
project=self.project,
@ -1289,7 +1289,7 @@ class SubscriptionControllerTest(ControllerBaseTest):
subscription = self.subscription_controller.get(self.source, s_id,
project=self.project)
self.assertEqual(True, subscription['confirmed'])
self.assertTrue(subscription['confirmed'])
def test_confirm_with_nonexist_subscription(self):
s_id = 'fake-id'