openstack/zun
Code Issues Proposed changes

Handle io_service_bytes_recursive is None

Browse Source 
Also add B324 to bandit skip list for python3.9+

Change-Id: I8b2a5e55dda141b342ab696377f02fa62b811597
This commit is contained in:
Hongbin Lu 2022-12-10 15:18:54 +00:00
parent f7f67cbf75
commit 7bddd4f42c
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tox.ini
View File

@ -30,9 +30,10 @@ commands =
doc8 -e .rst specs/ doc/source/ CONTRIBUTING.rst HACKING.rst README.rst
bash tools/flake8wrap.sh {posargs}
# The following bandit tests are being skipped:
# B303 - Use of insecure MD2, MD4, or MD5 hash function.
# B303 - Use of insecure MD2, MD4, or MD5 hash function for python<3.9
# B324 - Prohibit list calls: md5, sha1 for python>=3.9
# B604 - unction call with shell=True parameter identified, possible security issue.
bandit -r zun -x tests -n5 -ll --skip B303,B604
bandit -r zun -x tests -n5 -ll --skip B303,B324,B604
[testenv:venv]
basepython = python3

2
zun/container/docker/driver.py
View File

@ -988,7 +988,7 @@ class DockerDriver(driver.BaseDriver, driver.ContainerDriver,
blk_stats = res['blkio_stats']['io_service_bytes_recursive']
io_read = 0
io_write = 0
for item in blk_stats:
for item in (blk_stats or []):
if 'Read' == item['op']:
io_read = io_read + item['value']
if 'Write' == item['op']: