From c17a75d9753f5f4c2b3eb6a853d06bb001cbd867 Mon Sep 17 00:00:00 2001 From: Hongbin Lu Date: Sun, 17 Jun 2018 21:30:33 +0000 Subject: [PATCH] Fix some issues in API microversion doc * The samples should pass the pep8 test (add spaces around # noqa). * Add an item under "Other necessary changes" about updating the API version for tests. Change-Id: I6c98b24b8e3aa5f92d7a7a156994a1200682c6c4 --- doc/source/contributor/api-microversion.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/source/contributor/api-microversion.rst b/doc/source/contributor/api-microversion.rst index a6fd4c532..8eab89ae4 100644 --- a/doc/source/contributor/api-microversion.rst +++ b/doc/source/contributor/api-microversion.rst @@ -229,7 +229,7 @@ In the controller class:: def my_api_method(self, req, id): .... method_1 ... - @base.Controller.api_version("1.4") #noqa + @base.Controller.api_version("1.4") # noqa def my_api_method(self, req, id): .... method_2 ... @@ -295,6 +295,8 @@ necessary to add changes to other places which describe your change: * Update the expected versions in affected tests, for example in ``zun/tests/unit/api/controllers/test_root.py``. +* Update ``CURRENT_VERSION`` in ``zun/tests/unit/api/base.py``. + * Make a new commit to python-zunclient and update corresponding files to enable the newly added microversion API.