recordsansible/ara
Code Issues Proposed changes

Set exit code to 1 if at least one linter fails.

Browse Source 
Change-Id: I802a7e4221d35c5a0c5f7a1320ea267b1e59d1fc
This commit is contained in:
Florian Apolloner 2018-11-05 20:33:38 +01:00 committed by David Moreau Simard
parent ed9cf21ce9
commit 8f4e1ac20d
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/linters.sh
View File

@ -20,6 +20,7 @@
tests=$(dirname $0) tests=$(dirname $0)
export PROJECT_ROOT=$(cd `dirname $tests` && pwd -P) export PROJECT_ROOT=$(cd `dirname $tests` && pwd -P)
export PROJECT_LIB="${PROJECT_ROOT}/ara" export PROJECT_LIB="${PROJECT_ROOT}/ara"
ret=0
function banner() { function banner() {
echo echo
@ -40,14 +41,25 @@ fi
banner black banner black
time black --diff --check "${PROJECT_LIB}" time black --diff --check "${PROJECT_LIB}"
ret+=$?
banner isort banner isort
time isort --recursive --check-only --diff "${PROJECT_LIB}" time isort --recursive --check-only --diff "${PROJECT_LIB}"
ret+=$?
banner flake8 banner flake8
time flake8 "${PROJECT_LIB}" time flake8 "${PROJECT_LIB}"
ret+=$?
# B303 - Use of insecure MD2, MD4, or MD5 hash function. # B303 - Use of insecure MD2, MD4, or MD5 hash function.
# We're using sha1 to generate a hash of file contents. # We're using sha1 to generate a hash of file contents.
banner bandit banner bandit
time bandit -r "${PROJECT_LIB}" --skip B303 time bandit -r "${PROJECT_LIB}" --skip B303
ret+=$?
if [ $ret -gt 0 ]
then
echo
echo "At least one linter detected errors!"
exit 1
fi