starlingx/metal
Code Issues Proposed changes

Revert "Supress implicit-fallthrough warnings."

Browse Source 
This reverts commit 717f285c64.

This proposed changed is not compatible with the old GCC 4.3, a better patch needs to be done compatible with both gcc versions.

Change-Id: I657a4b92f1d30dac16d3a611baec8140ade3ad80
This commit is contained in:
Erich Cordoba 2019-06-20 21:56:00 +00:00
parent 717f285c64
commit 05a7f2f4d3
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mtce/src/common/nodeClass.cpp
View File

@ -826,7 +826,6 @@ struct nodeLinkClass::node* nodeLinkClass::getEventBaseNode ( libEvent_enum requ
return ptr ; return ptr ;
} }
__attribute__ ((fallthrough));
} }
case VIM_HOST_DISABLED: case VIM_HOST_DISABLED:
case VIM_HOST_ENABLED: case VIM_HOST_ENABLED:
@ -840,7 +839,6 @@ struct nodeLinkClass::node* nodeLinkClass::getEventBaseNode ( libEvent_enum requ
return ptr ; return ptr ;
} }
__attribute__ ((fallthrough));
} }
case BARBICAN_GET_SECRET: case BARBICAN_GET_SECRET:
case BARBICAN_READ_SECRET: case BARBICAN_READ_SECRET:

4
mtce/src/maintenance/mtcNodeHdlrs.cpp
View File

@ -3232,7 +3232,6 @@ int nodeLinkClass::offline_handler ( struct nodeLinkClass::node * node_ptr )
node_ptr->offlineStage = MTC_OFFLINE__SEND_MTCALIVE ; node_ptr->offlineStage = MTC_OFFLINE__SEND_MTCALIVE ;
/* fall through on start */ /* fall through on start */
__attribute__ ((fallthrough));
} }
case MTC_OFFLINE__SEND_MTCALIVE: case MTC_OFFLINE__SEND_MTCALIVE:
{ {
@ -3871,7 +3870,6 @@ int nodeLinkClass::reset_handler ( struct nodeLinkClass::node * node_ptr )
} }
node_ptr->power_action_retries = MTC_RESET_ACTION_RETRY_COUNT ; node_ptr->power_action_retries = MTC_RESET_ACTION_RETRY_COUNT ;
/* the fall through is intentional */ /* the fall through is intentional */
__attribute__ ((fallthrough));
} }
case MTC_RESET__REQ_SEND: case MTC_RESET__REQ_SEND:
{ {
@ -4694,7 +4692,6 @@ int nodeLinkClass::power_handler ( struct nodeLinkClass::node * node_ptr )
node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ; node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ;
//the fall through to MTC_POWEROFF__REQ_SEND is intentional //the fall through to MTC_POWEROFF__REQ_SEND is intentional
__attribute__ ((fallthrough));
} }
case MTC_POWEROFF__REQ_SEND: case MTC_POWEROFF__REQ_SEND:
{ {
@ -4854,7 +4851,6 @@ int nodeLinkClass::power_handler ( struct nodeLinkClass::node * node_ptr )
node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ; node_ptr->power_action_retries = MTC_POWER_ACTION_RETRY_COUNT ;
powerStageChange ( node_ptr , MTC_POWERON__POWER_STATUS ); powerStageChange ( node_ptr , MTC_POWERON__POWER_STATUS );
//the fall through to MTC_POWERON__REQ_SEND is intentional //the fall through to MTC_POWERON__REQ_SEND is intentional
__attribute__ ((fallthrough));
} }
case MTC_POWERON__POWER_STATUS: case MTC_POWERON__POWER_STATUS:
{ {