starlingx/metrics-server-armada-app
Code Issues Proposed changes

Remove CPU and memory requests for metrics server

Browse Source 
This commit removes the resources.requests.cpu and
resources.requests.memory fields from the deployment.

By eliminating these resource requests, the deployment is no
longer tied to specific guaranteed allocations, allowing for
more flexible and dynamic use of available resources. This
aligns with the behavior of previous metrics server versions.

Additionally, there should be no CPU allocation in 'platform'
pods as they end up using the CPU resource pool of 'application'
due to a limitation in the implementation of CPU isolation
present in the system.

Closes-bug: 2076940

Test Plan:
    PASS: Build package
    PASS: App upload/apply/update/remove/delete
    PASS: Verify that the values shown in the metrics server
          deployment describe for the metrics-server and
          addon-resizer containers do not have values in
          'resource.requests' for cpu and memory
    PASS: Run sample application

Change-Id: Ia018f5410b2c807682d05d1edf14c543159984a8
Signed-off-by: Gabriel de Araújo Cabral <gabriel.cabral@windriver.com>
This commit is contained in:
Gabriel de Araújo Cabral 2024-08-13 16:41:58 -03:00
parent 37f2da8373
commit 8bf3798c1b
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
stx-metrics-server-helm/stx-metrics-server-helm/fluxcd-manifests/metrics-server/metrics-server-static-overrides.yaml
View File

@ -19,3 +19,9 @@ tolerations:
effect: "NoSchedule"
nodeSelector:
node-role.kubernetes.io/control-plane: ""
resources: null
addonResizer:
resources:
requests: null