5539db9dcf
Flake8 and Hacking offer stricter style checks than pep8. This submission fixes these codes: E305 expected 2 blank lines after class or function definition, found 1 E722 do not use bare except' F841 local variable 'blah' is assigned to but never used H101: Use TODO(NAME) H201: no 'except:' at least use 'except Exception:' H237: module commands is removed in Python 3 H238: old style class declaration, use new style(inherit from `object`) This submission enables 2 additional checks that are off by default H106 vim config in files H203 Use assertIs(Not)None to check for None 8 hacking codes and 2 flake8 types were added to the ignore list and will be fixed by later updates. An optional hacking code H904 will be enabled and the code fixed by a later commit Story: 2003499 Task: 26195 Change-Id: I48f99fc0dd41addc574c81cee6662600faeb8e75 Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
120 lines
3.9 KiB
INI
120 lines
3.9 KiB
INI
[tox]
|
||
envlist = linters,pep8
|
||
minversion = 2.3
|
||
skipsdist = True
|
||
|
||
[testenv]
|
||
basepython = python3
|
||
install_command = pip install -U {opts} {packages}
|
||
setenv = VIRTUAL_ENV={envdir}
|
||
OS_STDOUT_CAPTURE=1
|
||
OS_STDERR_CAPTURE=1
|
||
OS_TEST_TIMEOUT=60
|
||
PYTHONDONTWRITEBYTECODE=True
|
||
commands = find {toxinidir} -type f -not -path '{toxinidir}/.tox/*' -not -path '*/__pycache__/*' -name '*.py[c|o]' -delete
|
||
deps = -r{toxinidir}/requirements.txt
|
||
-r{toxinidir}/test-requirements.txt
|
||
|
||
[testenv:linters]
|
||
whitelist_externals = bash
|
||
commands =
|
||
bash -c "find {toxinidir} \
|
||
\( -name middleware/io-monitor/recipes-common/io-monitor/io-monitor/io_monitor/test-tools/yaml/* -prune \) \
|
||
-o \( -name .tox -prune \) \
|
||
-o -type f -name '*.yaml' \
|
||
-print0 | xargs -0 yamllint"
|
||
|
||
[flake8]
|
||
# Temporarily ignoring these warnings
|
||
# E116 unexpected indentation (comment)
|
||
# E121 continuation line under-indented for hanging indent
|
||
# E122 continuation line missing indentation or outdented
|
||
# E123 closing bracket does not match indentation of opening bracket
|
||
# E124 closing bracket does not match visual indentation
|
||
# E126 continuation line over-indented for hanging indent
|
||
# E127 continuation line over-indented for visual indent
|
||
# E128 continuation line under-indented for visual indent
|
||
# E129 visually indented line with same indent as next logical line
|
||
# E225 missing whitespace around operator
|
||
# E226 missing whitespace around arithmetic operator
|
||
# E231 missing whitespace after ':'
|
||
# E241 multiple spaces after
|
||
# E261 at least two spaces before inline comment
|
||
# E265 block comment should start with '# '
|
||
# E501 line too long
|
||
# E712 comparison to bool should be reworded
|
||
# - hacking codes -
|
||
# H102: license header not found
|
||
# H104: File contains nothing but comments
|
||
# H301: one import per line
|
||
# H306: imports not in alphabetical order
|
||
# H401: docstring should not start with a space
|
||
# H404: multi line docstring should start without a leading new line
|
||
# H405: multi line docstring summary not separated with an empty line
|
||
# H501: Do not use self.__dict__ for string formatting
|
||
# - flake8 codes -
|
||
# F401 '<module>' imported but unused
|
||
# F821 undefined name 'unicode' (python3 specific)
|
||
ignore = E116,E121,E122,E123,E124,E126,E127,E128,E129,E225,E226,E231,E241,E261,E265,E501,E712,
|
||
H102,H104,H301,H306,H401,H404,H405,H501,
|
||
F401,F821,
|
||
# H106 Don’t put vim configuration in source files (off by default).
|
||
# H203 Use assertIs(Not)None to check for None (off by default).
|
||
# TODO: enable: H904 Delay string interpolations at logging calls (off by default).
|
||
enable-extensions = H106,H203
|
||
|
||
[testenv:pep8]
|
||
usedevelop = False
|
||
skip_install = True
|
||
deps =
|
||
hacking
|
||
flake8
|
||
commands =
|
||
flake8
|
||
|
||
[testenv:venv]
|
||
commands = {posargs}
|
||
|
||
[nosetests]
|
||
verbosity=2
|
||
|
||
[testenv:py27]
|
||
basepython = python2.7
|
||
deps = {[testenv]deps}
|
||
{toxinidir}/nfv/nfv-client
|
||
{toxinidir}/nfv/nfv-common
|
||
{toxinidir}/nfv/nfv-plugins
|
||
{toxinidir}/nfv/nfv-vim
|
||
whitelist_externals = cp
|
||
find
|
||
recreate = True
|
||
commands = {[testenv]commands}
|
||
cp -v nfv/nfv-tests/nfv_unit_tests/test_data/nfv_vim_db_18.03_GA {envdir}/
|
||
nosetests --exe -w nfv/nfv-tests/nfv_unit_tests/tests/ '{posargs}'
|
||
|
||
[testenv:pylint]
|
||
basepython = python2.7
|
||
deps = {[testenv]deps}
|
||
{toxinidir}/nfv/nfv-client
|
||
{toxinidir}/nfv/nfv-common
|
||
{toxinidir}/nfv/nfv-plugins
|
||
{toxinidir}/nfv/nfv-vim
|
||
{toxinidir}/../stx-fault/fm-api
|
||
iso8601
|
||
keyring
|
||
kombu
|
||
kubernetes
|
||
passlib
|
||
pecan
|
||
pyparsing
|
||
wsme
|
||
pylint
|
||
whitelist_externals = cp
|
||
find
|
||
commands = pylint nfv/nfv-client/nfv_client \
|
||
nfv/nfv-common/nfv_common \
|
||
nfv/nfv-plugins/nfv_plugins \
|
||
nfv/nfv-vim/nfv_vim \
|
||
--rcfile=nfv/nfv-tests/nfv_unit_tests/pylint.rc
|
||
|