Remove unused default Agents Daemonset

This change aims to remove the default daemonsets agents that are being
created but are not being used.
The _daemonset_overrides.tpl file, creates the daemonsets with
overrides and still creates the default daemonsets that end up not
being used.

The solution for this was by patching openstack-helm-infra removing a
section that aggregate the default daemonset to a global list.
In order to not remove the neutron-netns-cleanup-cron-default, an
override for this was created in the static overrides under the name
neutron-netns-cleanup-cron-openstack-control-plane.

Before the patch we had 25 daemonsets and 8 of them were not being used.
After the patch been applied we now have 17 daemonsets and all of them are being used.

Test Plan:

PASS: build-pkg -c -l openstack
PASS: build openstack tarball
PASS: Upload and Apply openstack tarball on standard system
PASS: *default* daemonsets are not deployed in openstack ns
PASS: New daemonset neutron-netns-cleanup-cron-openstack-control-plane
      deployed in openstack ns
PASS: Launch 2x Guest instances (centos-guest VMs)
PASS: Access instances through a remote console
PASS: Ping instances from remote console (all to all)
PASS: Ping instances from external server in the management network

Story: 2011304
Task: 51652

Change-Id: I0f83a8bf43ad4803820fdca22f77ceb182f30e9f
Signed-off-by: kgoncalv <kayo.goncalvesdacosta@windriver.com>
Co-authored-by: Ingo Almendros <ingo.almendrosgirao@windriver.com>

openstack-helm-infra/debian/deb_folder/patches/0020-removed-section-to-add-default-daemonset-to-global-l.patch

@@ -0,0 +1,27 @@
+From 45e6c1ad9a4791ad125bd95efc52f03c68a4736a Mon Sep 17 00:00:00 2001
+From: kgoncalv <kayo.goncalvesdacosta@windriver.com>
+Date: Mon, 3 Feb 2025 11:02:34 -0300
+Subject: [PATCH] removed section to add default daemonset to global list
+
+---
+ helm-toolkit/templates/utils/_daemonset_overrides.tpl | 4 ----
+ 1 file changed, 4 deletions(-)
+
+diff --git a/helm-toolkit/templates/utils/_daemonset_overrides.tpl b/helm-toolkit/templates/utils/_daemonset_overrides.tpl
+index 5f769753..cce14dd6 100644
+--- a/helm-toolkit/templates/utils/_daemonset_overrides.tpl
++++ b/helm-toolkit/templates/utils/_daemonset_overrides.tpl
+@@ -227,10 +227,6 @@ limitations under the License.
+   {{- $root_conf_copy4 := dict "Values" $root_conf_copy3 }}
+   {{- $_ := set $context.Values.__default "nodeData" $root_conf_copy4 }}
+ 
+-  {{/* add to global list */}}
+-  {{- $list_aggregate := append $context.Values.__daemonset_list $context.Values.__default }}
+-  {{- $_ := set $context.Values "__daemonset_list" $list_aggregate }}
+-
+   {{- range $current_dict := $context.Values.__daemonset_list }}
+ 
+     {{- $context_novalues := omit $context "Values" }}
+-- 
+2.34.1
+

openstack-helm-infra/debian/deb_folder/patches/series

@@ -17,3 +17,4 @@
 0017-Add-Kubernetes-name-label-to-helm-toolkit-template.patch
 0018-Add-support-for-multiple-hosts-in-a-daemonset.patch
 0019-Fix-upversion-breaking-changes.patch
+0020-removed-section-to-add-default-daemonset-to-global-l.patch

stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/neutron/neutron-static-overrides.yaml

@@ -182,6 +182,14 @@ dependencies:
     ovs_agent:
       pod: null
 conf:
+  overrides:
+    neutron_netns-cleanup-cron:
+      labels:
+        - conf: {}
+          label:
+            key: openstack-control-plane
+            values:
+              - enabled
   neutron:
     DEFAULT:
       l3_ha: false