From 8f4da191ac2fd45e7feadab9e6dffc0598260d13 Mon Sep 17 00:00:00 2001
From: Luis Sampaio <luis.sampaio@windriver.com>
Date: Tue, 2 Nov 2021 12:21:22 -0700
Subject: [PATCH] Add option to run unit tests during builds

build-pkgs will send the parameter 'run_tests' in the request to
the API endpoint 'pkgbuilder/addtask' and depending on this
parameter it will set the nocheck env variable or not.

Story: 2008846
Task: 43750

Depends-On: https://review.opendev.org/c/starlingx/root/+/816391

Signed-off-by: Luis Sampaio <luis.sampaio@windriver.com>
Change-Id: I7c627894a95cc14fa5627328b2e255bfbb893ee2
---
 stx/toCOPY/pkgbuilder/app.py        | 11 ++++++++---
 stx/toCOPY/pkgbuilder/debbuilder.py | 12 ++++++++----
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/stx/toCOPY/pkgbuilder/app.py b/stx/toCOPY/pkgbuilder/app.py
index de45fbf17..f55718795 100644
--- a/stx/toCOPY/pkgbuilder/app.py
+++ b/stx/toCOPY/pkgbuilder/app.py
@@ -88,7 +88,7 @@ def add_chroot():
 @app.route('/pkgbuilder/addtask', methods=['GET'])
 def add_task():
     response = {}
-    attrs = ['user', 'project', 'dsc', 'type', 'name', 'mode']
+    attrs = ['user', 'project', 'dsc', 'type', 'name', 'mode', 'run_tests']
     if not all(t in request.form for t in attrs):
         log.error("Invalid request to add task")
         response['status'] = 'fail'
@@ -98,8 +98,13 @@ def add_task():
         user = request.form['user']
         project = request.form['project']
 
-        task_info = {'package': request.form['name'],
-                     'dsc': request.form['dsc'], 'type': request.form['type']}
+        task_info = {
+            'package': request.form['name'],
+            'dsc': request.form['dsc'],
+            'type': request.form['type'],
+            'run_tests': request.form['run_tests']
+            }
+
         response = dbuilder.add_task(user, project, task_info)
         log.info("Reply to add task, response=%s", str(response))
     return jsonify(response)
diff --git a/stx/toCOPY/pkgbuilder/debbuilder.py b/stx/toCOPY/pkgbuilder/debbuilder.py
index 73f270c14..131dca95e 100644
--- a/stx/toCOPY/pkgbuilder/debbuilder.py
+++ b/stx/toCOPY/pkgbuilder/debbuilder.py
@@ -211,15 +211,19 @@ class Debbuilder:
             response['msg'] = dsc_target + ' does not exist'
             return response
 
-        # Disable unit tests globally to speed up builds
-        nocheck = os.environ
-        nocheck["DEB_BUILD_OPTIONS"] = "nocheck"
         bcommand = ' '.join([BUILD_ENGINE, '-d', DEBDIST, '-c', chroot,
                             '--build-dir', build_dir, dsc_target])
         self.logger.debug("Build command: %s" % bcommand)
 
         self._state = 'works'
-        p = subprocess.Popen(bcommand, shell=True, env=nocheck)
+
+        # verify if tests need to be executed
+        if task_info['run_tests'] == 'True':
+            p = subprocess.Popen(bcommand, shell=True)
+        else:
+            self.logger.debug("No tests needed, setting DEB_BUILD_OPTIONS=nocheck")
+            p = subprocess.Popen(bcommand, shell=True, env={**os.environ, 'DEB_BUILD_OPTIONS': 'nocheck'})
+
         self.sbuild_processes.setdefault(user, []).append(p)
 
         response['status'] = 'success'