feb152c085
When an Action table is created with a 'danger' action_type and a single handler method for a single object, the 'selection' and 'help' parameters are empty. This causes the pop-up message to be incomplete. For example: "You have selected: . Please confirm your selection. " This patch fixes this behaviour by displaying the message with the selected objects only when one or more objects are selected. Otherwise, it only asks for confirmation. Closes-Bug: 2000799 Test Plan: PASS: Build python3-django-horizon package including these changes. PASS: Test the behaviour for single delete actions. For example: Create a patch strategy and press the "Delete" action. Verify the following message is displayed in the pop-up message: "Please confirm your selection. This action cannot be undone." PASS: Test the behaviour for multiple delete actions. For example: Upload more than one patch, select them and click on the 'Delete' action. Verify the following message is displayed: You have selected: "22.12_NRR_INSVC", "22.12_RESTART_FAILURE_INSVC". Please confirm your selection. This action cannot be undone. Signed-off-by: Enzo Candotti <enzo.candotti@windriver.com> Change-Id: I85bc5c8155466e14a1a5fa84d54ed22032437f88
82 lines
2.2 KiB
INI
82 lines
2.2 KiB
INI
[tox]
|
|
envlist = linters,pep8
|
|
minversion = 2.3
|
|
skipsdist = True
|
|
|
|
[testenv]
|
|
basepython = python3.9
|
|
install_command = pip install \
|
|
-v -v -v \
|
|
-U \
|
|
-c{env:UPPER_CONSTRAINTS_FILE:https://opendev.org/starlingx/root/raw/branch/master/build-tools/requirements/debian/upper-constraints.txt} \
|
|
{opts} {packages}
|
|
setenv = VIRTUAL_ENV={envdir}
|
|
OS_STDOUT_CAPTURE=1
|
|
OS_STDERR_CAPTURE=1
|
|
OS_TEST_TIMEOUT=60
|
|
deps = -r{toxinidir}/test-requirements.txt
|
|
|
|
[testenv:linters]
|
|
allowlist_externals = bash
|
|
commands =
|
|
bash -c "find {toxinidir} \
|
|
-not \( -type d -name .?\* -prune \) \
|
|
-type f \
|
|
-not -name \*~ \
|
|
-not -name \*.md \
|
|
-name \*.sh \
|
|
-print0 | xargs -r -n 1 -0 bashate -v"
|
|
bash -c "find {toxinidir} \
|
|
-path '{toxinidir}/.tox' -a -prune \
|
|
-o -name '*.yaml' \
|
|
-print0 | xargs -0 yamllint"
|
|
|
|
[flake8]
|
|
# E123, E125 skipped as they are invalid PEP-8.
|
|
# E501 skipped because some of the code files include templates
|
|
# that end up quite wide
|
|
# H405: multi line docstring summary not separated with an empty line
|
|
show-source = True
|
|
ignore = E123,E125,E501,H405
|
|
exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,release-tag-*
|
|
import-order-style = google
|
|
|
|
|
|
[testenv:pep8]
|
|
usedevelop = False
|
|
description =
|
|
Run style checks.
|
|
|
|
|
|
commands =
|
|
flake8
|
|
|
|
|
|
[testenv:venv]
|
|
commands = {posargs}
|
|
|
|
[testenv:docs]
|
|
basepython = python3
|
|
deps = -r{toxinidir}/doc/requirements.txt
|
|
commands =
|
|
rm -rf doc/build
|
|
sphinx-build -a -E -W -d doc/build/doctrees -b html doc/source doc/build/html
|
|
allowlist_externals = rm
|
|
|
|
[testenv:releasenotes]
|
|
basepython = python3
|
|
deps = -r{toxinidir}/doc/requirements.txt
|
|
commands =
|
|
rm -rf releasenotes/build
|
|
sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
|
|
allowlist_externals =
|
|
rm
|
|
reno
|
|
|
|
[testenv:newnote]
|
|
# Re-use the releasenotes venv
|
|
basepython = python3
|
|
envdir = {toxworkdir}/releasenotes
|
|
deps = -r{toxinidir}/doc/requirements.txt
|
|
commands = reno new {posargs}
|