windmill/ansible-role-zuul
Code Issues Proposed changes

Fix path issue with roles_path

Browse Source 
- address ansible-lint issues with test.yaml
  - fix init.d issue on ubuntu-xenial

Change-Id: I8a992ee448b25abd62065baf54230b81c1bf48b2
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This commit is contained in:
Paul Belanger 2016-08-12 20:56:32 -04:00
parent 3e2496e28e
commit 390b5157d9
No known key found for this signature in database
GPG Key ID: 611A80832067AF38
5 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
files/etc/init.d/zuul-launcher
View File

@ -1,6 +1,6 @@
#! /bin/sh #! /bin/sh
### BEGIN INIT INFO ### BEGIN INIT INFO
# Provides: zuul # Provides: zuul-launcher
# Required-Start: $remote_fs $syslog # Required-Start: $remote_fs $syslog
# Required-Stop: $remote_fs $syslog # Required-Stop: $remote_fs $syslog
# Default-Start: 2 3 4 5 # Default-Start: 2 3 4 5

2
files/etc/init.d/zuul-merger
View File

@ -1,6 +1,6 @@
#! /bin/sh #! /bin/sh
### BEGIN INIT INFO ### BEGIN INIT INFO
# Provides: zuul # Provides: zuul-merger
# Required-Start: $remote_fs $syslog # Required-Start: $remote_fs $syslog
# Required-Stop: $remote_fs $syslog # Required-Stop: $remote_fs $syslog
# Default-Start: 2 3 4 5 # Default-Start: 2 3 4 5

2
files/etc/init.d/zuul-server
View File

@ -1,6 +1,6 @@
#! /bin/sh #! /bin/sh
### BEGIN INIT INFO ### BEGIN INIT INFO
# Provides: zuul # Provides: zuul-server
# Required-Start: $remote_fs $syslog # Required-Start: $remote_fs $syslog
# Required-Stop: $remote_fs $syslog # Required-Stop: $remote_fs $syslog
# Default-Start: 2 3 4 5 # Default-Start: 2 3 4 5

2
tests/ansible.cfg
View File

@ -1,2 +1,2 @@
[defaults] [defaults]
roles_path = .. roles_path = ../..

3
tests/test.yaml
View File

@ -29,13 +29,16 @@
post_tasks: post_tasks:
- name: Ensure zuul_user_name is zuul. - name: Ensure zuul_user_name is zuul.
shell: /usr/bin/getent passwd zuul shell: /usr/bin/getent passwd zuul
tags: skip_ansible_lint
- name: Ensure zuul_user_group is zuul. - name: Ensure zuul_user_group is zuul.
shell: /usr/bin/getent group zuul shell: /usr/bin/getent group zuul
tags: skip_ansible_lint
- name: Register zuul_user_home_getent. - name: Register zuul_user_home_getent.
shell: '/usr/bin/getent passwd zuul | cut -d: -f6' shell: '/usr/bin/getent passwd zuul | cut -d: -f6'
register: zuul_user_home_getent register: zuul_user_home_getent
tags: skip_ansible_lint
- name: Assert zuul_user_home is /var/lib/zuul. - name: Assert zuul_user_home is /var/lib/zuul.
assert: assert: