windmill/ansible-role-zuul
Code Issues Proposed changes

Ensure we have python installed for testing

Browse Source 
Also fix / ignore linting errors.

Change-Id: I9bb1b658a1e731f1d61753b958f3c23dc45f3542
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This commit is contained in:
Paul Belanger 2020-12-02 11:20:52 -05:00
parent 7954e0d563
commit a2a78e7ef5
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bindep.txt
View File

@ -4,13 +4,14 @@
git git
libffi-dev [platform:dpkg] libffi-dev [platform:dpkg]
libffi-devel [platform:rpm] libffi-devel [platform:rpm]
libselinux-python [platform:rpm]
libssl-dev [platform:dpkg] libssl-dev [platform:dpkg]
openssl-devel [platform:rpm] openssl-devel [platform:rpm]
python2-dnf [platform:fedora] python3-dnf [platform:fedora]
python3-libselinux [platform:rpm]
python3-pip [test]
python3-setuptools [test]
# NOTE(pabelanger): This is because of a bug in zuul, when zuul-scheduler starts # NOTE(pabelanger): This is because of a bug in zuul, when zuul-scheduler starts
# it will fail unless it cannot connect to zookeeper. However, zuul should be # it will fail unless it cannot connect to zookeeper. However, zuul should be
# smart enough to try forever to connect. # smart enough to try forever to connect.
zookeeperd [platform:dpkg] zookeeperd [platform:dpkg]
zookeeper [platform:fedora]

1
tests/collect-logs.yaml
View File

@ -6,6 +6,7 @@
- name: Ensure journald logs directory exists - name: Ensure journald logs directory exists
file: file:
mode: 0755
path: "{{ __log_dir }}" path: "{{ __log_dir }}"
state: directory state: directory

2
tox.ini
View File

@ -37,7 +37,7 @@ commands =
flake8 flake8
# Ansible Lint Check # Ansible Lint Check
bash -c "find . -not -path '*/\.*' -type f -regex '.*.y[a]?ml' -print0 | \ bash -c "find . -not -path '*/\.*' -type f -regex '.*.y[a]?ml' -print0 | \
xargs -t -n1 -0 ansible-lint -x 306" xargs -t -n1 -0 ansible-lint -x 106,306"
# Ansible Syntax Check # Ansible Syntax Check
bash -c "find tests -type f -regex '.*.y[a]?ml' -print | xargs -t -n1 \ bash -c "find tests -type f -regex '.*.y[a]?ml' -print | xargs -t -n1 \
ansible-playbook --syntax-check -i tests/inventory \ ansible-playbook --syntax-check -i tests/inventory \