Fix truthy value should be true or false warnings

Running yamllint, this exposed the follow warnings. Lets clean them up
before we switch to molecule.

Change-Id: I7eec334124e8c5eecb5a0b5670f0e512ef50a607
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

defaults/main.yaml

@@ -150,32 +150,32 @@ zuul_file_zuul_web_service_config_manage: true
 zuul_file_zuul_web_service_config_group: root
 zuul_file_zuul_web_service_config_owner: root
 
-zuul_service_zuul_executor_daemon_reload: yes
-zuul_service_zuul_executor_enabled: yes
+zuul_service_zuul_executor_daemon_reload: true
+zuul_service_zuul_executor_enabled: true
 zuul_service_zuul_executor_manage: true
 zuul_service_zuul_executor_name: zuul-executor.service
 zuul_service_zuul_executor_state: started
 
-zuul_service_zuul_fingergw_daemon_reload: yes
-zuul_service_zuul_fingergw_enabled: yes
+zuul_service_zuul_fingergw_daemon_reload: true
+zuul_service_zuul_fingergw_enabled: true
 zuul_service_zuul_fingergw_manage: true
 zuul_service_zuul_fingergw_name: zuul-fingergw.service
 zuul_service_zuul_fingergw_state: started
 
-zuul_service_zuul_merger_daemon_reload: yes
-zuul_service_zuul_merger_enabled: yes
+zuul_service_zuul_merger_daemon_reload: true
+zuul_service_zuul_merger_enabled: true
 zuul_service_zuul_merger_manage: true
 zuul_service_zuul_merger_name: zuul-merger.service
 zuul_service_zuul_merger_state: started
 
-zuul_service_zuul_scheduler_daemon_reload: yes
-zuul_service_zuul_scheduler_enabled: yes
+zuul_service_zuul_scheduler_daemon_reload: true
+zuul_service_zuul_scheduler_enabled: true
 zuul_service_zuul_scheduler_manage: true
 zuul_service_zuul_scheduler_name: zuul-scheduler.service
 zuul_service_zuul_scheduler_state: started
 
-zuul_service_zuul_web_daemon_reload: yes
-zuul_service_zuul_web_enabled: yes
+zuul_service_zuul_web_daemon_reload: true
+zuul_service_zuul_web_enabled: true
 zuul_service_zuul_web_manage: true
 zuul_service_zuul_web_name: zuul-web.service
 zuul_service_zuul_web_state: started

handlers/main.yaml

@@ -13,7 +13,7 @@
 # under the License.
 ---
 - name: Reload zuul-scheduler
-  become: yes
+  become: true
   service:
     name: zuul-scheduler
     state: reloaded

tasks/config.yaml

@@ -13,7 +13,7 @@
 # under the License.
 ---
 - name: Create required directories.
-  become: yes
+  become: true
   file:
     group: "{{ zuul_user_group }}"
     owner: "{{ zuul_user_name }}"
@@ -25,7 +25,7 @@
     - /var/log/zuul
 
 - name: Install gearman logging file.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_gearman_logging_conf_dest }}"
     group: "{{ zuul_file_gearman_logging_conf_group }}"
@@ -36,7 +36,7 @@
   notify: Reload zuul-scheduler
 
 - name: Install executor logging file.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_executor_logging_conf_dest }}"
     group: "{{ zuul_file_executor_logging_conf_group }}"
@@ -46,7 +46,7 @@
   register: zuul_file_executor_logging_conf
 
 - name: Install fingergw logging file.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_fingergw_logging_conf_dest }}"
     group: "{{ zuul_file_fingergw_logging_conf_group }}"
@@ -56,7 +56,7 @@
   register: zuul_file_fingergw_logging_conf
 
 - name: Install merger logging file.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_merger_logging_conf_dest }}"
     group: "{{ zuul_file_merger_logging_conf_group }}"
@@ -66,7 +66,7 @@
   register: zuul_file_merger_logging_conf
 
 - name: Install scheduler logging file.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_scheduler_logging_conf_dest }}"
     group: "{{ zuul_file_scheduler_logging_conf_group }}"
@@ -77,7 +77,7 @@
   notify: Reload zuul-scheduler
 
 - name: Install zuul gearman ssl ca configuration.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_gearman_ssl_ca_dest }}"
     group: "{{ zuul_file_gearman_ssl_ca_group }}"
@@ -87,7 +87,7 @@
   register: zuul_file_gearman_ssl_ca
 
 - name: Install zuul gearman ssl cert configuration.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_gearman_ssl_cert_dest }}"
     group: "{{ zuul_file_gearman_ssl_cert_group }}"
@@ -97,7 +97,7 @@
   register: zuul_file_gearman_ssl_cert
 
 - name: Install zuul gearman ssl key configuration.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_gearman_ssl_key_dest }}"
     group: "{{ zuul_file_gearman_ssl_key_group }}"
@@ -107,7 +107,7 @@
   register: zuul_file_gearman_ssl_key
 
 - name: Install web logging file.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_web_logging_conf_dest }}"
     group: "{{ zuul_file_web_logging_conf_group }}"
@@ -117,7 +117,7 @@
   register: zuul_file_web_logging_conf
 
 - name: Install zuul main.yaml configuration.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_main_yaml_dest }}"
     group: "{{ zuul_file_main_yaml_group }}"
@@ -129,7 +129,7 @@
     - Reload zuul-scheduler
 
 - name: Install zuul configuration.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_conf_dest }}"
     group: "{{ zuul_file_zuul_conf_group }}"

tasks/install.yaml

@@ -18,7 +18,7 @@
   when: zuul_build_depends is not defined
 
 - name: Ensure build dependencies are installed.
-  become: yes
+  become: true
   package:
     name: "{{ zuul_build_depends }}"
     state: installed

tasks/install/pip.yaml

@@ -13,7 +13,7 @@
 # under the License.
 ---
 - name: Install zuul using pip.
-  become: yes
+  become: true
   pip:
     executable: "{{ zuul_pip_executable|default(omit) }}"
     editable : "{{ zuul_pip_editable|default(omit) }}"

tasks/pre.yaml

@@ -13,14 +13,14 @@
 # under the License.
 ---
 - name: Create group account.
-  become: yes
+  become: true
   group:
     name: "{{ zuul_user_group }}"
 
 - name: Create user account.
-  become: yes
+  become: true
   user:
-    createhome: yes
+    createhome: true
     home: "{{ zuul_user_home }}"
     group: "{{ zuul_user_group }}"
     name: "{{ zuul_user_name }}"

tasks/service.yaml

@@ -163,7 +163,7 @@
   when: zuul_file_zuul_web_service_config_src is not defined
 
 - name: Install zuul-executor service into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_executor_service_dest }}"
     group: "{{ zuul_file_zuul_executor_service_group }}"
@@ -174,7 +174,7 @@
   when: zuul_file_zuul_executor_service_manage
 
 - name: Create zuul-executor service config directory.
-  become: yes
+  become: true
   file:
     group: "{{ zuul_file_zuul_executor_service_config_group }}"
     owner: "{{ zuul_file_zuul_executor_service_config_owner }}"
@@ -183,7 +183,7 @@
   when: zuul_file_zuul_executor_service_config_manage
 
 - name: Install zuul-executor service config into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_executor_service_config_dest }}"
     group: "{{ zuul_file_zuul_executor_service_config_group }}"
@@ -194,7 +194,7 @@
   when: zuul_file_zuul_executor_service_config_manage
 
 - name: Install zuul-fingergw service into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_fingergw_service_dest }}"
     group: "{{ zuul_file_zuul_fingergw_service_group }}"
@@ -205,7 +205,7 @@
   when: zuul_file_zuul_fingergw_service_manage
 
 - name: Create zuul-fingergw service config directory.
-  become: yes
+  become: true
   file:
     group: "{{ zuul_file_zuul_fingergw_service_config_group }}"
     owner: "{{ zuul_file_zuul_fingergw_service_config_owner }}"
@@ -214,7 +214,7 @@
   when: zuul_file_zuul_fingergw_service_config_manage
 
 - name: Install zuul-fingergw service config into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_fingergw_service_config_dest }}"
     group: "{{ zuul_file_zuul_fingergw_service_config_group }}"
@@ -225,7 +225,7 @@
   when: zuul_file_zuul_fingergw_service_config_manage
 
 - name: Install zuul-merger service into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_merger_service_dest }}"
     group: "{{ zuul_file_zuul_merger_service_group }}"
@@ -236,7 +236,7 @@
   when: zuul_file_zuul_merger_service_manage
 
 - name: Create zuul-merger service config directory.
-  become: yes
+  become: true
   file:
     group: "{{ zuul_file_zuul_merger_service_config_group }}"
     owner: "{{ zuul_file_zuul_merger_service_config_owner }}"
@@ -245,7 +245,7 @@
   when: zuul_file_zuul_merger_service_config_manage
 
 - name: Install zuul-merger service config into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_merger_service_config_dest }}"
     group: "{{ zuul_file_zuul_merger_service_config_group }}"
@@ -256,7 +256,7 @@
   when: zuul_file_zuul_merger_service_config_manage
 
 - name: Install zuul-scheduler service into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_scheduler_service_dest }}"
     group: "{{ zuul_file_zuul_scheduler_service_group }}"
@@ -267,7 +267,7 @@
   when: zuul_file_zuul_scheduler_service_manage
 
 - name: Create zuul-scheduler service config directory.
-  become: yes
+  become: true
   file:
     group: "{{ zuul_file_zuul_scheduler_service_config_group }}"
     owner: "{{ zuul_file_zuul_scheduler_service_config_owner }}"
@@ -276,7 +276,7 @@
   when: zuul_file_zuul_scheduler_service_config_manage
 
 - name: Install zuul-scheduler service config into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_scheduler_service_config_dest }}"
     group: "{{ zuul_file_zuul_scheduler_service_config_group }}"
@@ -287,7 +287,7 @@
   when: zuul_file_zuul_scheduler_service_config_manage
 
 - name: Install zuul-web service into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_web_service_dest }}"
     group: "{{ zuul_file_zuul_web_service_group }}"
@@ -298,7 +298,7 @@
   when: zuul_file_zuul_web_service_manage
 
 - name: Create zuul-web service config directory.
-  become: yes
+  become: true
   file:
     group: "{{ zuul_file_zuul_web_service_config_group }}"
     owner: "{{ zuul_file_zuul_web_service_config_owner }}"
@@ -307,7 +307,7 @@
   when: zuul_file_zuul_web_service_config_manage
 
 - name: Install zuul-web service config into place.
-  become: yes
+  become: true
   template:
     dest: "{{ zuul_file_zuul_web_service_config_dest }}"
     group: "{{ zuul_file_zuul_web_service_config_group }}"
@@ -318,7 +318,7 @@
   when: zuul_file_zuul_web_service_config_manage
 
 - name: Enable zuul-executor service.
-  become: yes
+  become: true
   systemd:
     daemon_reload: "{{ zuul_service_zuul_executor_daemon_reload }}"
     enabled: "{{ zuul_service_zuul_executor_enabled }}"
@@ -328,7 +328,7 @@
   when: zuul_service_zuul_executor_manage
 
 - name: Enable zuul-fingergw service.
-  become: yes
+  become: true
   systemd:
     daemon_reload: "{{ zuul_service_zuul_fingergw_daemon_reload }}"
     enabled: "{{ zuul_service_zuul_fingergw_enabled }}"
@@ -338,7 +338,7 @@
   when: zuul_service_zuul_fingergw_manage
 
 - name: Enable zuul-merger service.
-  become: yes
+  become: true
   systemd:
     daemon_reload: "{{ zuul_service_zuul_merger_daemon_reload }}"
     enabled: "{{ zuul_service_zuul_merger_enabled }}"
@@ -348,7 +348,7 @@
   when: zuul_service_zuul_merger_manage
 
 - name: Enable zuul-scheduler service.
-  become: yes
+  become: true
   systemd:
     daemon_reload: "{{ zuul_service_zuul_scheduler_daemon_reload }}"
     enabled: "{{ zuul_service_zuul_scheduler_enabled }}"
@@ -358,7 +358,7 @@
   when: zuul_service_zuul_scheduler_manage
 
 - name: Enable zuul-web service.
-  become: yes
+  become: true
   systemd:
     daemon_reload: "{{ zuul_service_zuul_web_daemon_reload }}"
     enabled: "{{ zuul_service_zuul_web_enabled }}"