Fixed pyling warnings, made something that is already installed actually be skipped

devstack/cfg_helpers.py

@@ -15,7 +15,6 @@
 #    under the License.
 
 from devstack import log as logging
-from devstack import settings
 
 LOG = logging.getLogger("devstack.cfg.helpers")
 

devstack/component.py

@@ -20,8 +20,6 @@ from devstack import downloader as down
 from devstack import exceptions as excp
 from devstack import importer
 from devstack import log as logging
-from devstack import packager
-from devstack import pip
 from devstack import settings
 from devstack import shell as sh
 from devstack import trace as tr
@@ -469,7 +467,7 @@ class PythonUninstallComponent(PkgUninstallComponent):
                 for (i, p) in enumerate(pips):
                     try:
                         self.pip_factory.get_packager_for(p).remove(p)
-                    except excp.ProcessExecutionError as e:
+                    except excp.ProcessExecutionError:
                         # NOTE(harlowja): pip seems to die if a pkg isn't there even in quiet mode
                         pass
                     p_bar.update(i + 1)

devstack/distro.py

@@ -22,7 +22,6 @@ import shlex
 
 import yaml
 
-from devstack import decorators
 from devstack import importer
 from devstack import log as logging
 from devstack import settings

devstack/packager.py

@@ -15,9 +15,7 @@
 #    under the License.
 
 import abc
-import collections
 
-from devstack import decorators
 from devstack import importer
 from devstack import log as logging
 from devstack import utils
@@ -43,10 +41,12 @@ class Packager(object):
     def install(self, pkg):
         name = pkg['name']
         version = pkg.get('version')
+        skip_install = False
         if name in self.registry.installed:
             existing_version = self.registry.installed[name]
             if version == existing_version:
                 LOG.debug("Skipping install of %r since it already happened.", name)
+                skip_install = True
             else:
                 if existing_version is not None:
                     if utils.versionize(existing_version) < utils.versionize(version):
@@ -55,11 +55,12 @@ class Packager(object):
                         LOG.warn("A request has come in for a older version of %r v(%s), when v(%s) was previously installed!", name, version, existing_version)
                 else:
                     LOG.warn("A request has come in for a different version of %r v(%s), when a unspecified version was previously installed!", name, version)
-        self._install(pkg)
-        LOG.debug("Noting that %r - v(%s) was installed.", name, (version or "??"))
-        self.registry.installed[name] = version
-        if name in self.registry.removed:
-            del(self.registry.removed[name])
+        if not skip_install:
+            self._install(pkg)
+            LOG.debug("Noting that %r - v(%s) was installed.", name, (version or "??"))
+            self.registry.installed[name] = version
+            if name in self.registry.removed:
+                del(self.registry.removed[name])
 
     def remove(self, pkg):
         removable = pkg.get('removable', True)

devstack/persona.py

@@ -16,7 +16,6 @@
 
 import yaml
 
-from devstack import decorators
 from devstack import exceptions as excp
 from devstack import log as logging
 from devstack import shell as sh

devstack/pip.py

@@ -15,10 +15,8 @@
 #    under the License.
 
 
-from devstack import exceptions as excp
 from devstack import log as logging
 from devstack import shell as sh
-from devstack import utils
 from devstack import packager as pack
 
 LOG = logging.getLogger("devstack.pip")