pylint should only fail test on fatal error
pylint will exit non-zero on any type of issue it uncovers, such as a code convention issue. We only want to fail the tests if pylint discovers fatal issues. There are currently only a few errors and dozens of warnings. If we can get those cleaned up then we can cause the test to fail when new errors (or warnings) are introduced.
This commit is contained in:
parent
9406fc5d64
commit
b5467e1638
@ -67,11 +67,11 @@ function run_pylint {
|
||||
# * 16 if a convention message was issued
|
||||
# * 32 on usage error
|
||||
echo "A fatal pylint error occurred!"
|
||||
FAILED_TESTS=1
|
||||
else
|
||||
if [ "$?" -eq "0" ]; then
|
||||
echo "Your code is perfect you code master!"
|
||||
else
|
||||
FAILED_TESTS=1
|
||||
echo "You are not yet a code master."
|
||||
grep -i "Your code" $output_filename
|
||||
echo "Check '$output_filename' for a full report."
|
||||
|
Loading…
x
Reference in New Issue
Block a user