From 86c9cc76d723105efd3946e63c3e254a930b2cdc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Vachon?= Date: Fri, 20 Feb 2015 14:38:12 -0500 Subject: [PATCH] JSLint: Unused variables raise errors --- Gruntfile.js | 1 - app/components/live/get_services.js | 4 ++-- app/components/live/notifications.js | 2 +- app/components/ng-justgage/ng-justgage.js | 2 +- app/components/sidebar/sidebar.js | 2 +- app/components/table/cell_duration/cell_duration.js | 2 +- app/components/table/cell_host_address/cell_host_address.js | 2 +- app/components/table/cell_hosts_host/cell_hosts_host.js | 2 +- app/components/table/cell_last_check/cell_last_check.js | 2 +- app/components/table/table.js | 4 ++-- app/components/tactical/current_health/current_health.js | 2 +- app/components/tactical/status_overview/status_overview.js | 2 +- app/components/tactical/tactical.js | 2 +- .../tactical/top_alert_producers/top_alert_producers.js | 2 +- app/components/topbar/topbar.js | 2 +- 15 files changed, 16 insertions(+), 17 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 0906acc..90ca0b9 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -61,7 +61,6 @@ module.exports = function (grunt) { ], directives: { node: true, - unparam: true, // TEMPORARY: Ignore unused params nomen: true, predef: [ // Global variables 'document', '$', '$get', diff --git a/app/components/live/get_services.js b/app/components/live/get_services.js index 8d4da49..99fbc7b 100644 --- a/app/components/live/get_services.js +++ b/app/components/live/get_services.js @@ -13,7 +13,7 @@ angular.module('adagios.live') }) .factory('getServices', ['$http', 'filterSuffixes', - function ($http, filterSuffixes, columns, filters, apiName) { + function ($http, filterSuffixes) { return function (columns, filters, apiName) { var filtersQuery = ''; @@ -36,7 +36,7 @@ angular.module('adagios.live') filtersQuery = createFiltersQuery(filters); return $http.get('/rest/status/json/' + apiName + '/?fields=' + columns + filtersQuery) - .error(function (data, status, headers, config) { + .error(function () { throw new Error('getServices : GET Request failed'); }); }; diff --git a/app/components/live/notifications.js b/app/components/live/notifications.js index 1d3b552..8e8bdfd 100644 --- a/app/components/live/notifications.js +++ b/app/components/live/notifications.js @@ -2,7 +2,7 @@ angular.module('adagios.live') - .factory('getProblems', ['$http', function ($http) { + .factory('getProblems', [function () { var problem_number = 44; return problem_number; diff --git a/app/components/ng-justgage/ng-justgage.js b/app/components/ng-justgage/ng-justgage.js index e3a1530..d0f1859 100644 --- a/app/components/ng-justgage/ng-justgage.js +++ b/app/components/ng-justgage/ng-justgage.js @@ -14,7 +14,7 @@ angular.module("ngJustGage", []) options: '=' }, template: '
', - link: function (scope, element, attrs) { + link: function (scope) { $timeout(function () { var options, key, graph; diff --git a/app/components/sidebar/sidebar.js b/app/components/sidebar/sidebar.js index 7ffe7c2..2a8ccc4 100644 --- a/app/components/sidebar/sidebar.js +++ b/app/components/sidebar/sidebar.js @@ -2,7 +2,7 @@ angular.module('adagios.sidebar', []) - .controller('SideBarCtrl', ['$scope', '$http', function ($scope, $http) { + .controller('SideBarCtrl', [function () { angular.noop(); }]) diff --git a/app/components/table/cell_duration/cell_duration.js b/app/components/table/cell_duration/cell_duration.js index 3fd799c..e9a9ed6 100644 --- a/app/components/table/cell_duration/cell_duration.js +++ b/app/components/table/cell_duration/cell_duration.js @@ -2,7 +2,7 @@ angular.module('adagios.table.cell_duration', ['adagios.table']) - .controller('CellDurationCtrl', ['$scope', function ($scope) { + .controller('CellDurationCtrl', [function () { angular.noop(); }]) diff --git a/app/components/table/cell_host_address/cell_host_address.js b/app/components/table/cell_host_address/cell_host_address.js index d58ced5..af9c1ec 100644 --- a/app/components/table/cell_host_address/cell_host_address.js +++ b/app/components/table/cell_host_address/cell_host_address.js @@ -2,7 +2,7 @@ angular.module('adagios.table.cell_host_address', ['adagios.table']) - .controller('CellHostAddressCtrl', ['$scope', function ($scope) { + .controller('CellHostAddressCtrl', [function () { angular.noop(); }]) diff --git a/app/components/table/cell_hosts_host/cell_hosts_host.js b/app/components/table/cell_hosts_host/cell_hosts_host.js index 2fbeaa9..f7e8e58 100644 --- a/app/components/table/cell_hosts_host/cell_hosts_host.js +++ b/app/components/table/cell_hosts_host/cell_hosts_host.js @@ -2,7 +2,7 @@ angular.module('adagios.table.cell_hosts_host', ['adagios.table']) - .controller('CellHostsHostCtrl', ['$scope', function ($scope) { + .controller('CellHostsHostCtrl', [function () { angular.noop(); }]) diff --git a/app/components/table/cell_last_check/cell_last_check.js b/app/components/table/cell_last_check/cell_last_check.js index 756910a..df1268b 100644 --- a/app/components/table/cell_last_check/cell_last_check.js +++ b/app/components/table/cell_last_check/cell_last_check.js @@ -2,7 +2,7 @@ angular.module('adagios.table.cell_last_check', ['adagios.table']) - .controller('CellLastCheckCtrl', ['$scope', function ($scope) { + .controller('CellLastCheckCtrl', [function () { angular.noop(); }]) diff --git a/app/components/table/table.js b/app/components/table/table.js index 132a685..1c23fea 100644 --- a/app/components/table/table.js +++ b/app/components/table/table.js @@ -16,7 +16,7 @@ angular.module('adagios.table', ['adagios.live', filters: {}, cellToFieldsMap: {} }) - .controller('TableCtrl', ['$scope', 'getServices', 'readConfig', 'tableConfig', function ($scope, getServices, readConfig, tableConfig) { + .controller('TableCtrl', ['$scope', 'getServices', 'tableConfig', function ($scope, getServices, tableConfig) { var requestFields = [], filters = JSON.parse(tableConfig.filters), @@ -30,7 +30,7 @@ angular.module('adagios.table', ['adagios.live', $scope.cellIndexes.push(i); } - angular.forEach($scope.cellsName, function (key, value) { + angular.forEach($scope.cellsName, function (key) { angular.forEach(tableConfig.cellToFieldsMap[key], function (_value) { requestFields.push(_value); }); diff --git a/app/components/tactical/current_health/current_health.js b/app/components/tactical/current_health/current_health.js index 14eca90..abd023f 100644 --- a/app/components/tactical/current_health/current_health.js +++ b/app/components/tactical/current_health/current_health.js @@ -2,7 +2,7 @@ angular.module('adagios.tactical.current_health', ['ngRoute', 'ngJustGage' ]) - .controller('TacticalCurrentHealth', ['$scope', '$http', function ($scope, $http) { + .controller('TacticalCurrentHealth', ['$scope', function ($scope) { $scope.hosts = 75.2; $scope.services = 94.4; }]) diff --git a/app/components/tactical/status_overview/status_overview.js b/app/components/tactical/status_overview/status_overview.js index 3dc424f..ff84ade 100644 --- a/app/components/tactical/status_overview/status_overview.js +++ b/app/components/tactical/status_overview/status_overview.js @@ -2,7 +2,7 @@ angular.module('adagios.tactical.status_overview', ['ngRoute' ]) - .controller('TacticalStatusOverViewCtrl', ['$scope', '$http', function ($scope, $http) { + .controller('TacticalStatusOverViewCtrl', ['$scope', function ($scope) { $scope.hosts = { "count": 104, "problems": 14 diff --git a/app/components/tactical/tactical.js b/app/components/tactical/tactical.js index d5e639c..9ead358 100644 --- a/app/components/tactical/tactical.js +++ b/app/components/tactical/tactical.js @@ -5,7 +5,7 @@ angular.module('adagios.tactical', ['adagios.tactical.status_overview', 'adagios.tactical.top_alert_producers' ]) - .controller('TacticalCtrl', ['$scope', '$http', function ($scope, $http) { + .controller('TacticalCtrl', [function () { // Togglable tabs // Don't follow hyperlinks diff --git a/app/components/tactical/top_alert_producers/top_alert_producers.js b/app/components/tactical/top_alert_producers/top_alert_producers.js index e65fddd..523e587 100644 --- a/app/components/tactical/top_alert_producers/top_alert_producers.js +++ b/app/components/tactical/top_alert_producers/top_alert_producers.js @@ -1,7 +1,7 @@ 'use strict'; angular.module('adagios.tactical.top_alert_producers', ['ngRoute' ]) - .controller('TacticalTopAlertProducers', ['$scope', '$http', function ($scope, $http) { + .controller('TacticalTopAlertProducers', ['$scope', function ($scope) { $scope.hosts = [ { "host_name": "server-18", diff --git a/app/components/topbar/topbar.js b/app/components/topbar/topbar.js index 7dacb60..ca488cd 100644 --- a/app/components/topbar/topbar.js +++ b/app/components/topbar/topbar.js @@ -2,7 +2,7 @@ angular.module('adagios.topbar', ['adagios.live']) - .controller('TopBarCtrl', ['$scope', '$http', 'getProblems', function ($scope, $http, getProblems) { + .controller('TopBarCtrl', ['$scope', 'getProblems', function ($scope, getProblems) { $scope.notifications = getProblems; }])