6dffe4c5b3
This patch wraps image build procedure into try-except-finally and appends some cleaning actions into finally section. If something goes wrong during image building, build environment will be cleaned up. 1) Stop running processes inside image chroot 2) Umount image chroot 3) Detach loop devices 4) Remove temporary files Closes-Bug: #1451817 Partially implements: blueprint ibp-build-ubuntu-images Change-Id: I7a7abf46f93fad3a3343dcf320781beec42f44bd
78 lines
2.8 KiB
Python
78 lines
2.8 KiB
Python
# Copyright 2014 Mirantis, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from fuel_agent import errors
|
|
from fuel_agent.openstack.common import log as logging
|
|
from fuel_agent.utils import utils
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
def make_fs(fs_type, fs_options, fs_label, dev):
|
|
# NOTE(agordeev): notice the different flag to force the fs creating
|
|
# ext* uses -F flag, xfs/mkswap uses -f flag.
|
|
cmd_line = []
|
|
cmd_name = 'mkswap'
|
|
if fs_type != 'swap':
|
|
cmd_name = 'mkfs.%s' % fs_type
|
|
cmd_line.append(cmd_name)
|
|
for opt in (fs_options, fs_label):
|
|
cmd_line.extend([s for s in opt.split(' ') if s])
|
|
cmd_line.append(dev)
|
|
utils.execute(*cmd_line)
|
|
|
|
|
|
def extend_fs(fs_type, fs_dev):
|
|
if fs_type in ('ext2', 'ext3', 'ext4'):
|
|
# ext3,4 file system can be mounted
|
|
# must be checked with e2fsck -f
|
|
utils.execute('e2fsck', '-yf', fs_dev, check_exit_code=[0])
|
|
utils.execute('resize2fs', fs_dev, check_exit_code=[0])
|
|
elif fs_type == 'xfs':
|
|
# xfs file system must be mounted
|
|
utils.execute('xfs_growfs', fs_dev, check_exit_code=[0])
|
|
else:
|
|
raise errors.FsUtilsError('Unsupported file system type')
|
|
|
|
|
|
def mount_fs(fs_type, fs_dev, fs_mount):
|
|
utils.execute('mount', '-t', fs_type, fs_dev, fs_mount,
|
|
check_exit_code=[0])
|
|
|
|
|
|
def mount_bind(chroot, path, path2=None):
|
|
if not path2:
|
|
path2 = path
|
|
utils.execute('mount', '--bind', path, chroot + path2,
|
|
check_exit_code=[0])
|
|
|
|
|
|
def umount_fs(fs_mount, try_lazy_umount=False):
|
|
try:
|
|
utils.execute('mountpoint', '-q', fs_mount, check_exit_code=[0])
|
|
except errors.ProcessExecutionError:
|
|
LOG.warning('%s is not a mountpoint, skipping umount', fs_mount)
|
|
else:
|
|
LOG.debug('Trying to umount {0}'.format(fs_mount))
|
|
try:
|
|
utils.execute('umount', fs_mount, check_exit_code=[0])
|
|
except errors.ProcessExecutionError as e:
|
|
if try_lazy_umount:
|
|
LOG.warning('Error while umounting {0} '
|
|
'exc={1}'.format(fs_mount, e.message))
|
|
LOG.debug('Trying lazy umounting {0}'.format(fs_mount))
|
|
utils.execute('umount', '-l', fs_mount, check_exit_code=[0])
|
|
else:
|
|
raise
|