x/bilean
Code Issues Proposed changes

Remove sqlite_db in set_defaults()

Browse Source 
Config option sqlite_db was removed from oslo.db[1].  Unit tests will be
failed if this argument is set, so we shouldn't set its default value.

[1]cc64f70105

Change-Id: I0f84690a538544a76d2ee536e2c6378d91055528
This commit is contained in:
lvdongbing 2017-06-22 15:05:23 +08:00
parent df84bb1d95
commit 6f880c827b
3 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bilean/tests/common/utils.py
View File

@ -44,9 +44,7 @@ def random_name():
def setup_dummy_db(): def setup_dummy_db():
options.cfg.set_defaults(options.database_opts, sqlite_synchronous=False) options.cfg.set_defaults(options.database_opts, sqlite_synchronous=False)
options.set_defaults(cfg.CONF, options.set_defaults(cfg.CONF, connection="sqlite://")
connection="sqlite://",
sqlite_db='bilean.db')
engine = get_engine() engine = get_engine()
db_api.db_sync(engine) db_api.db_sync(engine)
engine.connect() engine.connect()

1
setup.cfg
View File

@ -16,7 +16,6 @@ classifier =
Programming Language :: Python :: 2 Programming Language :: Python :: 2
Programming Language :: Python :: 2.7 Programming Language :: Python :: 2.7
Programming Language :: Python :: 3 Programming Language :: Python :: 3
Programming Language :: Python :: 3.4
Programming Language :: Python :: 3.5 Programming Language :: Python :: 3.5
[files] [files]

2
tox.ini
View File

@ -1,6 +1,6 @@
[tox] [tox]
minversion = 1.6 minversion = 1.6
envlist = py35,py34,py27,pep8 envlist = py35,py27,pep8
skipsdist = True skipsdist = True
[testenv] [testenv]