Improvements to Checks focused around Keystone Process count

+ Check for Keystone Process count on Controllers
+ Removed thread count check as it would inadvertently prevent correct
  checking of Keystone Process count
+ .gitignore files that should not be introduced into repo
+ Add .yml extension to checks group_vars

Change-Id: Iad7475a3d0839edf800d1ce4fdbd17a9b7b9a5f4

.gitignore

@@ -9,6 +9,11 @@ ansible/hosts
 # Prevent any fernet keys from sneaking into git repo
 ansible/browbeat/roles/keystone-token/files/[0-9]
 
+# Prevent Ansible Checks data/scripts from entering git repo:
+ansible/check/mysqltuner.pl
+ansible/bug_report.log
+ansible/mysql_report.log
+
 log/*
 
 # Swap files

ansible/check/group_vars/all.yml

@@ -1,5 +1,4 @@
 ---
-# vi:syntax=yaml
 result_dir: "{{inventory_dir}}/"
 
 mysql_tuner_script: https://raw.githubusercontent.com/major/MySQLTuner-perl/master/mysqltuner.pl

ansible/check/group_vars/compute.yml

@@ -20,6 +20,3 @@ checks:
     bz1264740:
         url: "https://bugzilla.redhat.com/show_bug.cgi?id=1264740"
         name: "RHEL OSP Director must be configure with nova-event-callback by default"
-
-
-# vi:syntax=yaml

ansible/check/group_vars/controller.yml

@@ -7,6 +7,8 @@ mariadb_max_connections: 4096
 mysqld_soft_fd: 16384
 nova_vif_timeout: 300
 netdev_max_backlog: 100000
+keystone_threads: 6
+keystone_processes: 2
 
 checks :
     bz1095811 :
@@ -56,4 +58,6 @@ checks :
         name: "Glance API wokres should be set to None , thereby defaulting to number of cores"
     glance_registry_workers:
         url: "https://bugzilla.redhat.com/show_bug.cgi?id=1361285"
-# vi:syntax=yaml
+    bz1347305:
+        url: "https://bugzilla.redhat.com/show_bug.cgi?id=1347305"
+        name: "Overcloud deployed with keystone as single process leads to abysmal performance"

ansible/check/group_vars/undercloud.yml

@@ -47,4 +47,3 @@ checks :
     bz1330980:
         url: "https://bugzilla.redhat.com/show_bug.cgi?id=1330980"
         name: "Undercloud deployed with 1 keystone worker and cpu_count for threads"
-# vi:syntax=yaml

ansible/check/roles/keystone/tasks/main.yml

@@ -34,30 +34,30 @@
 
 - debug: msg="Keystone deployed in:{{ keystone_deployment }}"
 
-- name: Keystone HTTP admin processes
+- name: Keystone HTTP admin processes (Undercloud)
-  command: egrep -o "processes=[0-9]+" /etc/httpd/conf.d/*keystone*admin.conf | egrep -o "[0-9]+"
+  shell: egrep -o "processes=[0-9]+" /etc/httpd/conf.d/*keystone*admin.conf | egrep -o "[0-9]+"
   register: bz1330980
   failed_when: bz1330980.stdout|int < keystone_processes
-  when: keystone_in_eventlet.stdout|int == 0
+  when: (keystone_in_eventlet.stdout|int == 0) and (inventory_hostname in groups.undercloud)
   ignore_errors: True
 
-- name: Keystone HTTP main processes
+- name: Keystone HTTP main processes (Undercloud)
-  command: egrep -o "processes=[0-9]+" /etc/httpd/conf.d/*keystone*main.conf | egrep -o "[0-9]+"
+  shell: egrep -o "processes=[0-9]+" /etc/httpd/conf.d/*keystone*main.conf | egrep -o "[0-9]+"
   register: bz1330980
   failed_when: bz1330980.stdout|int < keystone_processes
-  when: keystone_in_eventlet.stdout|int == 0
+  when: (keystone_in_eventlet.stdout|int == 0) and (inventory_hostname in groups.undercloud)
   ignore_errors: True
 
-- name: Keystone HTTP admin threads
+- name: Keystone HTTP admin processes (Controller)
-  command: egrep -o "threads=[0-9]+" /etc/httpd/conf.d/*keystone*admin.conf | egrep -o "[0-9]+"
+  shell: egrep -o "processes=[0-9]+" /etc/httpd/conf.d/*keystone*admin.conf | egrep -o "[0-9]+"
-  register: bz1330980
+  register: bz1347305
-  failed_when: bz1330980.stdout|int < keystone_threads
+  failed_when: bz1347305.stdout|int < keystone_processes
-  when: keystone_in_eventlet.stdout|int == 0
+  when: (keystone_in_eventlet.stdout|int == 0) and (inventory_hostname in groups.controller)
   ignore_errors: True
 
-- name: Keystone HTTP main threads
+- name: Keystone HTTP main processes (Controller)
-  command: egrep -o "threads=[0-9]+" /etc/httpd/conf.d/*keystone*main.conf | egrep -o "[0-9]+"
+  shell: egrep -o "processes=[0-9]+" /etc/httpd/conf.d/*keystone*main.conf | egrep -o "[0-9]+"
-  register: bz1330980
+  register: bz1347305
-  failed_when: bz1330980.stdout|int < keystone_threads
+  failed_when: bz1347305.stdout|int < keystone_processes
-  when: keystone_in_eventlet.stdout|int == 0
+  when: (keystone_in_eventlet.stdout|int == 0) and (inventory_hostname in groups.controller)
   ignore_errors: True