x/browbeat
Code Issues Proposed changes

Clean up linter

Browse Source 
Enable ANSIBLE0010, package installs should
not use latest. Package installs should use state=present with
or without a version.

Change-Id: Id9868d0170fcf715be473d121f9db809f6c7d528
Signed-off-by: Chuck Short <chucks@redhat.com>
This commit is contained in:
Chuck Short 2018-08-02 13:48:55 -04:00
parent 959bed59a5
commit 6d03698faa
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/check/roles/common/tasks/main.yml
View File

@ -9,7 +9,7 @@
ignore_errors: True ignore_errors: True
- name: Install Crudini if it is not there - name: Install Crudini if it is not there
yum: name=crudini state=latest yum: name=crudini state=present
when: crudini.rc == 1 when: crudini.rc == 1
- name: Get selinux mode - name: Get selinux mode

2
tox.ini
View File

@ -16,7 +16,7 @@ whitelist_externals = bash
commands = commands =
bash -c "cd ansible; find . -type f -regex '.*.y[a]?ml' -print0 | xargs -t -n1 -0 \ bash -c "cd ansible; find . -type f -regex '.*.y[a]?ml' -print0 | xargs -t -n1 -0 \
ansible-lint \ ansible-lint \
-x ANSIBLE0012,ANSIBLE0006,ANSIBLE0007,ANSIBLE0010,ANSIBLE0016" -x ANSIBLE0012,ANSIBLE0006,ANSIBLE0007,ANSIBLE0016"
pykwalify -d browbeat-config.yaml -s browbeat/schema/browbeat.yml pykwalify -d browbeat-config.yaml -s browbeat/schema/browbeat.yml
pykwalify -d browbeat-complete.yaml -s browbeat/schema/browbeat.yml pykwalify -d browbeat-complete.yaml -s browbeat/schema/browbeat.yml
bash -c "set -e; for config in $(ls conf/); do \ bash -c "set -e; for config in $(ls conf/); do \