x/browbeat
Code Issues Proposed changes

Fix pacemaker collectd plugin

Browse Source 
The pacemaker collectd plugin fails with the error
[error] Unhandled python exception in read callback: UnboundLocalError: local variable 'val' referenced before assignment
on OSP 16.2. This patch fixes the issue.

Change-Id: Ia004f3fb8c60f917d38ad580007e0757b4a20a44
This commit is contained in:
Sanjay Chari 2022-03-15 13:25:12 +05:30
parent b7f8230149
commit dd13782584
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
browbeat-containers/collectd-openstack/files/collectd_pacemaker_monitoring.py
View File

@ -42,6 +42,8 @@ def read_func():
"redis_resource_failures", "ovn_resource_failures", "cinder_resource_failures"] "redis_resource_failures", "ovn_resource_failures", "cinder_resource_failures"]
for component in components_list: for component in components_list:
val = 0
if component == "total_nodes": if component == "total_nodes":
for line in latest_output[-1::-1]: for line in latest_output[-1::-1]:
if "nodes configured" in line: if "nodes configured" in line:
@ -71,7 +73,6 @@ def read_func():
elif "resource_total_count" in component: elif "resource_total_count" in component:
resource = component.split("_")[0] resource = component.split("_")[0]
val = 0
# Flag to make sure that failures are not counted # Flag to make sure that failures are not counted
# in resource total count. # in resource total count.
is_failures_total = False is_failures_total = False
@ -93,7 +94,6 @@ def read_func():
elif "resource_master_count" in component: elif "resource_master_count" in component:
resource = component.split("_")[0] resource = component.split("_")[0]
val = 0
# Flag to make sure that failures are not counted # Flag to make sure that failures are not counted
# in resource master count # in resource master count
is_failures_master = False is_failures_master = False
@ -115,7 +115,6 @@ def read_func():
if "daemon_status" in component: if "daemon_status" in component:
daemon = component.split("_")[0] daemon = component.split("_")[0]
val = 0
for line in latest_output: for line in latest_output:
if daemon+":" in line and "active/enabled" in line: if daemon+":" in line and "active/enabled" in line:
val = 1 val = 1
@ -123,7 +122,6 @@ def read_func():
if "resource_failures" in component: if "resource_failures" in component:
resource = component.split("_")[0] resource = component.split("_")[0]
val = 0
is_failures = False is_failures = False
for line in latest_output[-1::-1]: for line in latest_output[-1::-1]:
if "Failed" in line: if "Failed" in line: