From 4bd0489427f8b1219eca0f3f492a7cf651f92fae Mon Sep 17 00:00:00 2001
From: Alessandro Pilotti <ap@pilotti.it>
Date: Tue, 13 Aug 2013 00:21:55 +0300
Subject: [PATCH] Adds ConfigDrive support for Windows XP

Windows XP does not support the WMI class Win32_Volume. This patch
replaces is with a call to the GetVolumeInformationW WIn32 API.
---
 .../metadata/services/configdrive/manager.py   | 18 +++++++++---------
 cloudbaseinit/osutils/base.py                  |  3 +++
 cloudbaseinit/osutils/windows.py               |  8 ++++++++
 3 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/cloudbaseinit/metadata/services/configdrive/manager.py b/cloudbaseinit/metadata/services/configdrive/manager.py
index 77ee233e..d2b5cf96 100644
--- a/cloudbaseinit/metadata/services/configdrive/manager.py
+++ b/cloudbaseinit/metadata/services/configdrive/manager.py
@@ -30,6 +30,7 @@ from cloudbaseinit.metadata.services.configdrive.windows.disk \
     import physical_disk
 from cloudbaseinit.metadata.services.configdrive.windows.disk \
     import virtual_disk
+from cloudbaseinit.osutils import factory as osutils_factory
 
 LOG = logging.getLogger(__name__)
 
@@ -44,19 +45,18 @@ class ConfigDriveManager(object):
         return l
 
     def _get_config_drive_cdrom_mount_point(self):
+        osutils = osutils_factory.OSUtilsFactory().get_os_utils()
+
         conn = wmi.WMI(moniker='//./root/cimv2')
         q = conn.query('SELECT Drive FROM Win32_CDROMDrive WHERE '
                        'MediaLoaded = True')
         for r in q:
-            drive = r.Drive + '\\'
-            q1 = conn.query('SELECT Label FROM Win32_Volume WHERE '
-                            'Name = \'%(drive)s\'' % locals())
-            for r1 in q1:
-                if r1.Label == "config-2" and \
-                    os.path.exists(os.path.join(drive,
-                                                'openstack\\latest\\'
-                                                'meta_data.json')):
-                    return drive
+            label = osutils.get_volume_label(r.Drive)
+            if label == "config-2" and \
+                os.path.exists(os.path.join(r.Drive,
+                                            'openstack\\latest\\'
+                                            'meta_data.json')):
+                return r.Drive + "\\"
         return None
 
     def _c_char_array_to_c_ushort(self, buf, offset):
diff --git a/cloudbaseinit/osutils/base.py b/cloudbaseinit/osutils/base.py
index f4217f98..3a38bf3b 100644
--- a/cloudbaseinit/osutils/base.py
+++ b/cloudbaseinit/osutils/base.py
@@ -90,3 +90,6 @@ class BaseOSUtils(object):
 
     def get_os_version(self):
         pass
+
+    def get_volume_label(self, drive):
+        pass
diff --git a/cloudbaseinit/osutils/windows.py b/cloudbaseinit/osutils/windows.py
index c30cf29c..88517891 100644
--- a/cloudbaseinit/osutils/windows.py
+++ b/cloudbaseinit/osutils/windows.py
@@ -374,3 +374,11 @@ class WindowsUtils(base.BaseOSUtils):
     def get_os_version(self):
         conn = wmi.WMI(moniker='//./root/cimv2')
         return conn.Win32_OperatingSystem()[0].Version
+
+    def get_volume_label(self, drive):
+        max_label_size = 261
+        label = ctypes.create_unicode_buffer(max_label_size)
+        ret_val = kernel32.GetVolumeInformationW(unicode(drive), label,
+                                                 max_label_size, 0, 0, 0, 0, 0)
+        if ret_val:
+            return label.value