1e790c13ad
A number of tests for aodh.sender.Sender are in aodh/test_plugin.py. Since aodh/test_sender.py was recently added, it makes sense to move the sender tests to this new location. The following tests were moved: * test_get_alarm_state_severity_low * test_get_alarm_state_severity_moderate * test_get_alarm_state_severity_critical The tests were refactored to use self.sender that is defined in TestSender/setUp(). Change-Id: I337c37b14f593183a46b8fd4b077c5b47bc791bc
187 lines
7.5 KiB
Python
187 lines
7.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2010-2011 OpenStack Foundation
|
|
# Copyright (c) 2017 Intel Corporation.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""Sender tests."""
|
|
|
|
import mock
|
|
import requests
|
|
import unittest
|
|
|
|
from collectd_ceilometer.aodh import sender as aodh_sender
|
|
from collections import OrderedDict
|
|
|
|
from collectd_ceilometer.common.meters import base
|
|
|
|
valid_resp = '[{"alarm_actions": [], "event_rule": {"query": [],'\
|
|
'"event_type": "events.gauge"}, "ok_actions": [],'\
|
|
'"name": "alarm", "severity": "moderate",'\
|
|
'"timestamp": "2017-08-22T06:22:46.790949", "enabled": true,'\
|
|
'"alarm_id": "11af9327-8c3a-4120-8a74-bbc672c90f0a",'\
|
|
'"time_constraints": [], "insufficient_data_actions": []}]'
|
|
|
|
valid_alarm_id = "valid_alarm_id"
|
|
|
|
|
|
class response(object):
|
|
|
|
__attrs__ = [
|
|
'_content', 'status_code', 'headers', 'url', 'history',
|
|
'encoding', 'reason', 'cookies', 'elapsed', 'request', 'text'
|
|
]
|
|
|
|
def __init__(self, text, code):
|
|
self.text = text
|
|
self.status_code = code
|
|
|
|
def raise_for_status(self):
|
|
pass
|
|
|
|
|
|
class TestSender(unittest.TestCase):
|
|
"""Test the Sender class."""
|
|
|
|
def setUp(self):
|
|
super(TestSender, self).setUp()
|
|
self.sender = aodh_sender.Sender()
|
|
|
|
@mock.patch.object(aodh_sender.Sender, "_get_remote_alarm_id",
|
|
autospec=True)
|
|
@mock.patch.object(aodh_sender.Sender, "_get_endpoint", autospec=True)
|
|
@mock.patch.object(aodh_sender.Sender, "_create_alarm", spec=callable)
|
|
def test_get_alarm_id_no_local_alarm(self, _create_alarm, _get_endpoint,
|
|
_get_remote_alarm_id):
|
|
"""Test the behaviour when the alarm id doesn't exist locally.
|
|
|
|
Set-up:
|
|
Test: call _get_alarm_id when no local alarm exists.
|
|
Expected behaviour:
|
|
* _get_remote_alarm_id is called
|
|
* self._alarm_ids is updated
|
|
"""
|
|
_get_remote_alarm_id.return_value = valid_alarm_id
|
|
|
|
alarm_id = self.sender._get_alarm_id("alarm", "critical", "link status",
|
|
"critical")
|
|
|
|
self.assertEqual(alarm_id, valid_alarm_id,
|
|
"_get_remote_alarm_id is not called")
|
|
_get_remote_alarm_id.assert_called_once_with(mock.ANY, mock.ANY,
|
|
"alarm")
|
|
_create_alarm.assert_not_called()
|
|
_get_endpoint.assert_called_once_with(mock.ANY, "aodh")
|
|
self.assertIn("alarm", self.sender._alarm_ids,
|
|
"self._alarm_ids is not updated")
|
|
|
|
@mock.patch.object(aodh_sender.Sender, "_create_alarm", spec=callable)
|
|
@mock.patch.object(requests, 'get', spec=callable)
|
|
def test_get_remote_alarm_id(self, get, _create_alarm):
|
|
"""Test behaviour of _get_remote_alarm_id
|
|
|
|
Set-up:
|
|
Test: Call _get_remote_alarm_id with typical parameters
|
|
Expected behaviour:
|
|
* requests.get is called with correct args
|
|
* Alarm ID is returned
|
|
"""
|
|
resp = response(valid_resp, 200)
|
|
get.return_value = resp
|
|
params = OrderedDict([(u"q.field", u"name"), (u"q.op", u"eq"),
|
|
(u"q.value", u"alarm")])
|
|
|
|
alarm_id = self.sender._get_remote_alarm_id(u"endpoint", u"alarm")
|
|
|
|
self.assertEqual(alarm_id, "11af9327-8c3a-4120-8a74-bbc672c90f0a",
|
|
"invalid alarm id")
|
|
_create_alarm.assert_not_called()
|
|
get.assert_called_once_with(u"endpoint/v2/alarms", params=params,
|
|
headers=mock.ANY, timeout=mock.ANY)
|
|
|
|
@mock.patch.object(aodh_sender.Sender, "_get_endpoint", autospec=True)
|
|
@mock.patch.object(aodh_sender.Sender, "_create_alarm", spec=callable)
|
|
@mock.patch.object(requests, 'get', spec=callable)
|
|
def test_get_alarm_id_not_found(self, get, _create_alarm, _get_endpoint):
|
|
"""Test behaviour of _get_alarm_id when alarm does not exist
|
|
|
|
Set up:
|
|
Test:
|
|
* call _get_alarm_id
|
|
* requests.get/sender._perform_request return an error
|
|
Expected behaviour: _create_alarm is called
|
|
"""
|
|
resp = response("some invalid response", 404)
|
|
get.return_value = resp
|
|
_create_alarm.return_value = valid_alarm_id
|
|
|
|
alarm_id = self.sender._get_alarm_id("alarm", "critical", "link status",
|
|
"critical")
|
|
|
|
_create_alarm.assert_called_once_with(
|
|
mock.ANY, "critical", "link status", "alarm", "critical")
|
|
_get_endpoint.assert_called_once_with(mock.ANY, "aodh")
|
|
self.assertEqual(alarm_id, valid_alarm_id, "invalid alarm id")
|
|
|
|
@mock.patch.object(base.Meter, 'collectd_severity', spec=callable)
|
|
def test_get_alarm_state_severity_low(self, severity):
|
|
"""Test _get_alarm_state if severity is 'low'.
|
|
|
|
Set-up: create a sender instance, set severity to low
|
|
Test: call _get_alarm_state method with severity=low
|
|
Expected-behaviour: returned state value should equal 'ok'
|
|
and won't equal 'alarm' or insufficient data'
|
|
"""
|
|
# run test for moderate severity
|
|
severity.return_value = 'low'
|
|
|
|
self.assertEqual('ok', self.sender._get_alarm_state('low'))
|
|
self.assertNotEqual('alarm', self.sender._get_alarm_state('low'))
|
|
self.assertNotEqual('insufficient data',
|
|
self.sender._get_alarm_state('low'))
|
|
|
|
@mock.patch.object(base.Meter, 'collectd_severity', spec=callable)
|
|
def test_get_alarm_state_severity_moderate(self, severity):
|
|
"""Test _get_alarm_state if severity is 'moderate'.
|
|
|
|
Set-up: create a sender instance, set severity to moderate
|
|
Test: call _get_alarm_state method with severity=moderate
|
|
Expected-behaviour: returned state value should equal 'alarm'
|
|
and won't equal 'ok' or insufficient data'
|
|
"""
|
|
# run test for moderate severity
|
|
severity.return_value = 'moderate'
|
|
|
|
self.assertEqual('alarm', self.sender._get_alarm_state('moderate'))
|
|
self.assertNotEqual('ok', self.sender._get_alarm_state('moderate'))
|
|
self.assertNotEqual('insufficient data',
|
|
self.sender._get_alarm_state('moderate'))
|
|
|
|
@mock.patch.object(base.Meter, 'collectd_severity', spec=callable)
|
|
def test_get_alarm_state_severity_critical(self, severity):
|
|
"""Test _get_alarm_state if severity is 'critical'.
|
|
|
|
Set-up: create a sender instance, set severity to critical
|
|
Test: call _get_alarm_state method with severity=critical
|
|
Expected-behaviour: returned state value should equal 'alarm'
|
|
and won't equal 'ok' or 'insufficient data'
|
|
"""
|
|
# run test for moderate severity
|
|
severity.return_value = 'critical'
|
|
|
|
self.assertEqual('alarm', self.sender._get_alarm_state('critical'))
|
|
self.assertNotEqual('okay', self.sender._get_alarm_state('critical'))
|
|
self.assertNotEqual('insufficient data',
|
|
self.sender._get_alarm_state('critical'))
|