x/openstack-resource-agents
Code Issues Proposed changes

Add bashate version >=0.5.0 as test dependency

Browse Source 
We have a lots of long heredocs lines in the OCF scripts and older bashate
versions consider these as E006 violations.
From version 0.5.0, bashate doesn't check heredocs, so we specify this
version as a dependency.

In addition, this commit turns on E006 violation checking again.

Change-Id: I1ff675dd587239f0b7fd65c15b8df57a39a2c72b
Signed-off-by: Norbert Illes <norbert.e.illes@ericsson.com>
This commit is contained in:
Norbert Illes 2016-03-07 11:19:54 +01:00
parent fa93525cea
commit a0b55d3329
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tox.ini
View File

@ -6,17 +6,12 @@ skipsdist = True
whitelist_externals = bash whitelist_externals = bash
[testenv:bashate] [testenv:bashate]
deps = bashate # NOTE: We have a lots of long heredocs lines in the OCF scripts and older
# NOTE: We ignore E006 violations (--ignore E006) only temporary. # bashate versions consider these as E006 violations.
# The reason is that the currently available bashate versions (<=0.4.0) are # From version 0.5.0, bashate doesn't check heredocs, so we specify this
# considering heredocs as normal code lines, hence lines longer than 79 columns # version as a dependency.
# in these sections are also considered as E006 violations. deps = bashate>=0.5.0
# Commit 649c7dc79948 in bashate repository modifies bashate to ignore long commands = bash -c "bashate --verbose {toxinidir}/ocf/*"
# lines in heredocs, but currently there is no bashate release which contains
# this commit.
# TODO: After a new bashate released, '--ignore E006' should be deleted and the
# newer bashate version should be specified as a dependency.
commands = bash -c "bashate --ignore E006 --verbose {toxinidir}/ocf/*"
[testenv:syntax-check] [testenv:syntax-check]
setenv = setenv =