x/openstack-resource-agents
Code Issues Proposed changes

Temporary ignore bashate E006 errors

Browse Source 
The currently available bashate releases are considering heredocs as
normal code lines, hence lines longer than 79 columns in these sections
are also considered as E006 violations. As the OCF scripts are
containing lots of heredocs, we are affected by this behaviour.
However, there is a commit in the bashate repository (649c7dc79948)
which modifies bashate to ignore long lines in heredocs.

Currently there is no bashate release which contains the above commit,
so we ignore E006 errors until a new bashate released.

Change-Id: I33a9737ce1ec7eddab0b24ddedefe5c17da03b7a
Partial-Bug: #1550203
Signed-off-by: Norbert Illes <norbert.e.illes@ericsson.com>
This commit is contained in:
Norbert Illes 2016-03-05 09:48:12 +01:00
parent 98a54ad759
commit fa93525cea
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tox.ini
View File

@ -7,7 +7,16 @@ whitelist_externals = bash
[testenv:bashate]
deps = bashate
commands = bash -c "bashate --verbose {toxinidir}/ocf/*"
# NOTE: We ignore E006 violations (--ignore E006) only temporary.
# The reason is that the currently available bashate versions (<=0.4.0) are
# considering heredocs as normal code lines, hence lines longer than 79 columns
# in these sections are also considered as E006 violations.
# Commit 649c7dc79948 in bashate repository modifies bashate to ignore long
# lines in heredocs, but currently there is no bashate release which contains
# this commit.
# TODO: After a new bashate released, '--ignore E006' should be deleted and the
# newer bashate version should be specified as a dependency.
commands = bash -c "bashate --ignore E006 --verbose {toxinidir}/ocf/*"
[testenv:syntax-check]
setenv =