Fix and enable gating on H306

H306, module imports should be in alphabetical order
This hacking check actually improves readability quite
a bit, as module imports can be sorted in groups (python stdlibs,
external imports, in-module imports)

Change-Id: I11dc9155fbfc84389f2a5956f393f705388f83ba

designateclient/auth.py

@@ -13,8 +13,9 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
-from urlparse import urlparse
+
 from requests.auth import AuthBase
+from urlparse import urlparse
 
 from keystoneclient.v2_0.client import Client
 

designateclient/cli/diagnostics.py

@@ -13,7 +13,9 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import logging
+
 from designateclient.cli import base
 
 LOG = logging.getLogger(__name__)

designateclient/cli/domains.py

@@ -13,7 +13,9 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import logging
+
 from designateclient.cli import base
 from designateclient.v1.domains import Domain
 

designateclient/cli/records.py

@@ -13,7 +13,9 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import logging
+
 from designateclient.cli import base
 from designateclient.v1.records import Record
 

designateclient/cli/servers.py

@@ -13,7 +13,9 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import logging
+
 from designateclient.cli import base
 from designateclient.v1.servers import Server
 

designateclient/cli/sync.py

@@ -14,6 +14,7 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 import logging
+
 from designateclient.cli import base
 
 LOG = logging.getLogger(__name__)

designateclient/cli/touch.py

@@ -13,7 +13,9 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import logging
+
 from designateclient.cli import base
 
 LOG = logging.getLogger(__name__)

designateclient/shell.py

@@ -13,8 +13,10 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import logging
 import os
+
 from cliff.app import App
 from cliff.commandmanager import CommandManager
 from designateclient.version import version_info as version

designateclient/utils.py

@@ -13,9 +13,12 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import os
 import pkg_resources
+
 import json
+
 from designateclient import exceptions
 
 

designateclient/v1/__init__.py

@@ -15,8 +15,9 @@
 # under the License.
 import requests
 from stevedore import extension
-from designateclient import exceptions
+
 from designateclient.auth import KeystoneAuth
+from designateclient import exceptions
 
 
 class Client(object):

designateclient/v1/domains.py

@@ -14,9 +14,10 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 import json
-from designateclient import warlock
+
 from designateclient import utils
 from designateclient.v1.base import CrudController
+from designateclient import warlock
 
 
 Domain = warlock.model_factory(utils.load_schema('v1', 'domain'))

designateclient/v1/records.py

@@ -13,11 +13,13 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import json
-from designateclient import warlock
+
 from designateclient import utils
 from designateclient.v1.base import CrudController
 from designateclient.v1.domains import Domain
+from designateclient import warlock
 
 
 Record = warlock.model_factory(utils.load_schema('v1', 'record'))

designateclient/v1/servers.py

@@ -13,10 +13,12 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+
 import json
-from designateclient import warlock
+
 from designateclient import utils
 from designateclient.v1.base import CrudController
+from designateclient import warlock
 
 
 Server = warlock.model_factory(utils.load_schema('v1', 'server'))

designateclient/warlock.py

@@ -15,8 +15,10 @@
 # Code copied from Warlock, as warlock depends on jsonschema==0.2
 # Hopefully we can upstream the changes ASAP.
 #
+
 import copy
 import logging
+
 import jsonschema
 
 LOG = logging.getLogger(__name__)

tox.ini

@@ -33,6 +33,6 @@ commands = python setup.py testr --coverage --testr-args='{posargs}'
 commands = {posargs}
 
 [flake8]
-ignore = H302,H306,H401,H402,H404
+ignore = H302,H401,H402,H404
 builtins = _
 exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools