x/python-tatuclient
Code Issues Proposed changes

Improve logging in designateclient

Browse Source 
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

This change corrects some incorrect indentations in logs

Change-Id: Ida8ab2958563f0752f20490f033922a60c1c1c01
This commit is contained in:
sonu.kumar 2015-11-25 16:12:55 +05:30
parent 18b94f4659
commit 849ce56a16
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
designateclient/v2/cli/reverse.py
View File

@ -118,4 +118,4 @@ class UnsetFloatingIPCommand(command.Command):
def take_action(self, parsed_args):
client = self.app.client_manager.dns
client.floatingips.unset(parsed_args.floatingip_id)
LOG.info('FloatingIP PTR %s was unset' % parsed_args.floatingip_id)
LOG.info('FloatingIP PTR %s was unset', parsed_args.floatingip_id)

6
designateclient/v2/cli/zones.py
View File

@ -250,7 +250,7 @@ class AbandonZoneCommand(command.Command):
client.zones.abandon(parsed_args.id)
LOG.info("Z %(zone_id)s abandoned" %
LOG.info("Z %(zone_id)s abandoned",
{"zone_id": parsed_args.id})
@ -268,7 +268,7 @@ class AXFRZoneCommand(command.Command):
client.zones.axfr(parsed_args.id)
LOG.info("Scheduled AXFR for zone %(zone_id)s" %
LOG.info("Scheduled AXFR for zone %(zone_id)s",
{"zone_id": parsed_args.id})
@ -376,7 +376,7 @@ class DeleteTransferRequestCommand(command.Command):
client.zone_transfers.delete_request(parsed_args.id)
LOG.info('Zone Transfer %s was deleted' % parsed_args.id)
LOG.info('Zone Transfer %s was deleted', parsed_args.id)
class AcceptTransferRequestCommand(command.Command):