From 3535c14668adddcf4a52a7e160edffbc1985e89e Mon Sep 17 00:00:00 2001
From: boding <longddropt@163.com>
Date: Tue, 15 Dec 2015 14:02:08 +0800
Subject: [PATCH] encapulate same codes into functions

use functions to avoid repeatly calling "cat" commad and make code cleaner

Change-Id: If8a2643eb99f9acfcd94d9f042216bbaec7718cc
---
 scripts/device-input-traffic.sh | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/scripts/device-input-traffic.sh b/scripts/device-input-traffic.sh
index f057c75..2dacbb0 100755
--- a/scripts/device-input-traffic.sh
+++ b/scripts/device-input-traffic.sh
@@ -3,16 +3,26 @@
 
 dev=${1:-eth0}
 
-packages=`cat /sys/class/net/$dev/statistics/rx_packets `
-bytes=`cat /sys/class/net/$dev/statistics/rx_bytes `
+function get_rx_packets()
+{
+    echo  `cat /sys/class/net/$dev/statistics/rx_packets `
+}
+
+function get_rx_bytes()
+{
+    echo `cat /sys/class/net/$dev/statistics/rx_bytes `
+}
+
+packages=$(get_rx_packets)
+bytes=$(get_rx_bytes)
 
 interval=3
 
 trap 'break' INT
 while [ 1 -eq 1 ]  ; do
     sleep $interval
-    n_packages=`cat /sys/class/net/$dev/statistics/rx_packets `
-    n_bytes=`cat /sys/class/net/$dev/statistics/rx_bytes `
+    n_packages=$(get_rx_packets)
+    n_bytes=$(get_rx_bytes)
     python -c "print '%0.2f pkt/s %0.2f byte/s' % ((float($n_packages-$packages)/int($interval), (float($n_bytes-$bytes)/int($interval))))"
     packages=$n_packages
     bytes=$n_bytes