Fix nova_generic_service resource

Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>

example-puppet.py

@@ -453,7 +453,7 @@ def setup_resources():
     #   come from https://github.com/openstack/puppet-nova/blob/5.1.0/manifests/params.pp
     nova_scheduler_puppet = vr.create('nova_scheduler_puppet', 'resources/nova_generic_service_puppet', {
         'title' : 'scheduler', 'package_name': 'nova-scheduler', 'service_name': 'nova-scheduler',
-    }[0]
+    })[0]
     signals.connect(node1, nova_scheduler_puppet)
 
     # NOVA COMPUTE

resources/nova_conductor_puppet/README.md

@@ -1,16 +1,5 @@
-# Nova conductor resource for puppet handler
+# Nova generic service resource for puppet handler
 
-Setup and configure the Nova conductor service.
+Setup and configure the Nova generic services.
-Note, it [should not](http://docs.openstack.org/juno/config-reference/content/section_conductor.html) be deployed on compute nodes.
 
-# Parameters
+source https://github.com/openstack/puppet-nova/blob/5.1.0/manifests/generic_service.pp
-
-source https://github.com/openstack/puppet-nova_conductor/blob/5.1.0/manifests/conductor.pp
-
- ``ensure_package``
-   (optional) The state of the nova conductor package
-   Defaults to 'present'
-
- ``workers``
-   (optional) Number of workers for OpenStack Conductor service
-   Defaults to undef (i.e. parameter will not be present)

resources/nova_generic_service_puppet/actions/remove.pp

@@ -1,4 +1,4 @@
-$title           = $resource['input']['title']['value']
+$service_title           = $resource['input']['title']['value']
 $package_name    = $resource['input']['package_name']['value']
 $service_name    = $resource['input']['service_name']['value']
 
@@ -6,7 +6,7 @@ exec { 'post-nova_config':
   command     => '/bin/echo "Nova config has changed"',
 }
 
-nova::generic_service { $title:
+nova::generic_service { $service_title:
   ensure_package => 'absent',
   enabled        => false,
   package_name   => $package_name,

resources/nova_generic_service_puppet/actions/run.pp

@@ -1,6 +1,6 @@
 $resource = hiera($::resource_name)
 
-$title           = $resource['input']['title']['value']
+$service_title           = $resource['input']['title']['value']
 $package_name    = $resource['input']['package_name']['value']
 $service_name    = $resource['input']['service_name']['value']
 $ensure_package  = $resource['input']['ensure_package']['value']
@@ -16,7 +16,7 @@ package { 'nova-common':
   ensure => $ensure_package,
 }
 
-nova::generic_service { $title:
+nova::generic_service { $service_title:
   enabled         => true,
   manage_service  => true,
   package_name    => $package_name,