Merge pull request #21 from Mirantis/bogdando/dev

Bogdando/dev

.gitignore

@@ -17,9 +17,12 @@ rs/
 
 solar.log
 x-venv/
+.tmp/
+modules/
 
 celery*.pid
 celery*.log
 
 *.dot
-*.png
+*.png
+resources_compiled.py

example-puppet.py

@@ -7,7 +7,7 @@ from solar.core import resource
 from solar.core.provider import  GitProvider
 from solar.core import signals
 from solar.core import validation
-from solar.core import virtual_resource as vr
+from solar.core.resource import virtual_resource as vr
 
 from solar.interfaces.db import get_db
 

main.yml

@@ -33,14 +33,19 @@
     - shell: gem build hiera-redis.gemspec && gem install hiera-redis-3.0.0.gem chdir=/root/hiera-redis
     - template: src=/vagrant/hiera.yaml dest=/etc/puppet/hiera.yaml
     - file: path=/etc/puppet/hieradata state=directory
+    # Make paths puppet 4 compatible
     - file: path=/etc/puppetlabs/code/ state=directory
     - file: src=/etc/puppet/hiera.yaml dest=/etc/puppetlabs/code/hiera.yaml state=link
     - apt: name=ruby-dev state=present
-    - shell: gem install librarian-puppet
+    - file: path=/var/tmp/puppet/modules state=directory owner=puppet
-    - file: path=/tmp/puppet-modules/modules state=directory
+    - file: path=/var/tmp/puppet/Puppetfile state=touch owner=puppet
-    - file: path=/tmp/puppet-modules/Puppetfile state=touch
     - file: path=/etc/puppet/modules state=absent
-    - file: src=/tmp/puppet-modules/modules dest=/etc/puppet/modules state=link
+    - file: path=/etc/puppetlabs/code/modules state=absent
+    - file: path=/etc/puppetlabs/code/hieradata state=absent
+    - file: src=/var/tmp/puppet/modules dest=/etc/puppet/modules state=link
+    - file: src=/var/tmp/puppet/modules dest=/etc/puppetlabs/code/modules state=link
+    - file: src=/etc/puppet/hieradata dest=/etc/puppetlabs/code/hieradata state=link
+    - shell: gem install librarian-puppet --no-ri --no-rdoc
 
       # Setup additional development tools
     - apt: name=vim state=present

resources/keystone_puppet/actions/run.pp

@@ -10,7 +10,7 @@ $port = $resource['input']['port']['value']
 
 class {'keystone':
   package_ensure       => 'present',
-  verbose              => True,
+  verbose              => true,
   catalog_type         => 'sql',
   admin_token          => $admin_token,
   database_connection  => "mysql://$db_user:$db_password@$ip/$db_name",

resources/keystone_puppet/actions/update.pp

@@ -1,5 +1,5 @@
 class {'keystone':
-  verbose         => True,
+  verbose         => true,
   catalog_type    => 'sql',
   admin_token     => '{{ admin_token }}',
   sql_connection  => 'mysql://{{ db_user }}:{{ db_password }}@{{ ip }}/{{ db_name }}',

resources/keystone_puppet/meta.yaml

@@ -25,7 +25,7 @@ input:
 
     git:
       schema: {repository: str!, branch: str!}
-      value: {repository: 'https://github.com/openstack/puppet-keystone', branch: 'stable/juno'}
+      value: {repository: 'https://github.com/openstack/puppet-keystone', branch: '5.1.0'}
 
 #    forge:
 #      schema: str!

solar/solar/core/handlers/puppet.py

@@ -98,7 +98,7 @@ class LibrarianPuppet(ResourceSSHMixin):
 
         puppetlabs = self._ssh_command(
             self.resource,
-            'sudo', 'cat', '/tmp/puppet-modules/Puppetfile'
+            'sudo', 'cat', '/var/tmp/puppet/Puppetfile'
         )
 
         git = self.resource.args['git'].value
@@ -134,14 +134,14 @@ class LibrarianPuppet(ResourceSSHMixin):
         self._scp_command(
             self.resource,
             '/tmp/Puppetfile',
-            '/tmp/puppet-modules/Puppetfile',
+            '/var/tmp/puppet/Puppetfile',
             use_sudo=True
         )
 
         self._ssh_command(
             self.resource,
             'sudo', 'librarian-puppet', 'install',
-            cwd='/tmp/puppet-modules'
+            cwd='/var/tmp/puppet'
         )