x/solar
Code Issues Proposed changes

Fix interface for generating pretty diff

Browse Source
This commit is contained in:
Dmitry Shulyak 2015-11-17 11:41:44 +02:00
parent b8180f29bc
commit 637596343b
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
solar/solar/cli/system_log.py
View File

@ -47,7 +47,7 @@ def stage(d):
for item in log: for item in log:
click.echo(data.compact(item)) click.echo(data.compact(item))
if d: if d:
for line in data.details(item): for line in data.details(item.diff):
click.echo(' '*4+line) click.echo(' '*4+line)
if not log: if not log:
click.echo('No changes') click.echo('No changes')
@ -60,7 +60,7 @@ def staged_item(uid):
click.echo('No staged changes for {}'.format(log_action)) click.echo('No staged changes for {}'.format(log_action))
else: else:
click.echo(data.compact(item)) click.echo(data.compact(item))
for line in data.details(item): for line in data.details(item.diff):
click.echo(' '*4+line) click.echo(' '*4+line)
@changes.command() @changes.command()
@ -89,7 +89,7 @@ def history(n, d, s):
click.echo(data.compact(item)) click.echo(data.compact(item))
if d: if d:
for line in data.details(item): for line in data.details(item.diff):
click.echo(' '*4+line) click.echo(' '*4+line)
if not log: if not log:
click.echo('No history') click.echo('No history')

3
solar/solar/system_log/data.py
View File

@ -31,8 +31,7 @@ def compact(logitem):
return 'log task={} uid={}'.format(logitem.log_action, logitem.uid) return 'log task={} uid={}'.format(logitem.log_action, logitem.uid)
def details(logitem): def details(diff):
diff = logitem.diff
rst = [] rst = []
for type_, val, change in diff: for type_, val, change in diff:
if type_ == 'add': if type_ == 'add':