x/stackalytics
Code Issues Proposed changes

Fix LP profile validation function

Browse Source 
Change-Id: I28f3412882126a5c2edec44cd1a680ab6534aaa0
This commit is contained in:
Ilya Shakhat 2015-02-06 12:55:38 +03:00
parent 716fbcaa64
commit 1fca64ab72
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
stackalytics/processor/utils.py
View File

@ -269,5 +269,6 @@ def normalize_company_draft(name):
def validate_lp_display_name(lp_profile):
if "<email address hidden>" == lp_profile['display_name']:
lp_profile['display_name'] = lp_profile['name']
if lp_profile:
if "<email address hidden>" == lp_profile['display_name']:
lp_profile['display_name'] = lp_profile['name']

13
tests/unit/test_utils.py
View File

@ -110,3 +110,16 @@ class TestUtils(testtools.TestCase):
self.assertEqual(normalized_company_names,
correct_normalized_company_names)
def test_validate_lp_display_name(self):
profile = dict(name='johnny', display_name='John Smith')
utils.validate_lp_display_name(profile)
self.assertEqual('John Smith', profile['display_name'])
profile = dict(name='johnny', display_name='<email address hidden>')
utils.validate_lp_display_name(profile)
self.assertEqual('johnny', profile['display_name'])
profile = None
utils.validate_lp_display_name(profile)
self.assertEqual(None, profile)